Bug 160289 – Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)

[Tim Horton]

Created attachment 284768 [details]
Patch

[Tim Horton]

Will write changelog and post for review tomorrow, just wanted to get EWS going.

[Tim Horton]

Created attachment 284795 [details]
Patch

[Tim Horton]

<rdar://problem/27553464>

[Simon Fraser (smfr)]

Comment on attachment 284795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284795&action=review

> Source/WebKit2/Platform/IPC/Connection.cpp:391
> +std::chrono::milliseconds Connection::timeoutRespectingIgnoreTimeoutsForTesting(std::chrono::milliseconds timeout) const
> +{
> +    return m_ignoreTimeoutsForTesting ? std::chrono::milliseconds::max() : timeout;
> +}

I thought we are moving away from std::chrono.

[Tim Horton]

(In reply to comment #5)
> Comment on attachment 284795 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284795&action=review
> 
> > Source/WebKit2/Platform/IPC/Connection.cpp:391
> > +std::chrono::milliseconds Connection::timeoutRespectingIgnoreTimeoutsForTesting(std::chrono::milliseconds timeout) const
> > +{
> > +    return m_ignoreTimeoutsForTesting ? std::chrono::milliseconds::max() : timeout;
> > +}
> 
> I thought we are moving away from std::chrono.

Sure, but this code is full of it still.

[Benjamin Poulain]

Comment on attachment 284795 [details]
Patch

+1. My code was assuming message ordering, which is wrong.

[Tim Horton]

https://trac.webkit.org/changeset/203842