Bug 160284 - API test WebKit2.AutoLayoutIntegration is a flaky timeout
Summary: API test WebKit2.AutoLayoutIntegration is a flaky timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-27 20:47 PDT by Ryan Haddad
Modified: 2016-09-28 21:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.63 KB, patch)
2016-09-28 17:14 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ryan Haddad 2016-07-27 20:50:36 PDT
Unfortunately, I do not have steps to reproduce this yet.
Comment 2 Ryan Haddad 2016-09-23 13:22:28 PDT
This is making the bots red often enough that I think we should look into getting this resolved sooner rather than later.
Comment 3 Alexey Proskuryakov 2016-09-23 15:57:12 PDT
This is quite reproducible:

while true; do run-api-tests --no-build WebKit2.AutoLayoutIntegration; done
Comment 4 Alexey Proskuryakov 2016-09-26 15:00:27 PDT
The test has become more flaky recently, we should fix or skip it soon.
Comment 5 Tim Horton 2016-09-26 15:39:51 PDT
I wonder if it got worse in https://trac.webkit.org/changeset/206247?
Comment 6 Ryan Haddad 2016-09-28 14:45:34 PDT
Disabled test in http://trac.webkit.org/projects/webkit/changeset/206553
Comment 7 Tim Horton 2016-09-28 16:31:59 PDT
It looks like it's usually the second to last test that gets stuck (the _setShouldExpandContentToViewHeightForAutoLayout one)
Comment 8 Tim Horton 2016-09-28 16:36:53 PDT
Getting stuck waiting for

[webView load:@"<div class='large'></div>" withWidth:50 expectingContentSize:NSMakeSize(100, 100) resettingWidth:NO];
Comment 9 Tim Horton 2016-09-28 16:54:42 PDT
The invalidateIntrinsicContentSize is coming in before the load finishes, and we don't get another after it completes.
Comment 10 Tim Horton 2016-09-28 17:14:45 PDT
Created attachment 290148 [details]
Patch
Comment 11 WebKit Commit Bot 2016-09-28 18:17:00 PDT
Comment on attachment 290148 [details]
Patch

Clearing flags on attachment: 290148

Committed r206572: <http://trac.webkit.org/changeset/206572>
Comment 12 WebKit Commit Bot 2016-09-28 18:17:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Alexey Proskuryakov 2016-09-28 21:48:26 PDT
👍🏻