Bug 160280 – [iOS] Add WKUIDelegate SPI for specifying that an attachment list is from a managed source

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[iOS] Add WKUIDelegate SPI for specifying that an attachment list is from a managed source

[Andy Estes]

<rdar://problem/27471815>

[Andy Estes]

Created attachment 284745 [details]
Patch

[Andy Estes]

Created attachment 284746 [details]
Patch

Comment on attachment 284746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284746&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:75
> +- (BOOL)_attachmentListSourceIsManagedForWebView:(WKWebView *)webView WK_API_AVAILABLE(ios(WK_IOS_TBA));

Instead of adding this and always calling two delegate methods, can you add a new method that returns both the array and the boolean, and only call that (if implemented by the delegate)?

[Andy Estes]

Created attachment 284749 [details]
Patch

Comment on attachment 284749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284749&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:75
> +- (NSArray *)_attachmentListForWebView:(WKWebView *)webView sourceIsManaged:(BOOL *)sourceIsManaged WK_API_AVAILABLE(ios(WK_IOS_TBA));

No space after BOOL.

[Andy Estes]

Created attachment 284751 [details]
patch for landing

[WebKit Commit Bot]

Comment on attachment 284751 [details]
patch for landing

Clearing flags on attachment: 284751

Committed r203809: <http://trac.webkit.org/changeset/203809>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.