Bug 160280 - [iOS] Add WKUIDelegate SPI for specifying that an attachment list is from a managed source
Summary: [iOS] Add WKUIDelegate SPI for specifying that an attachment list is from a m...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-27 17:13 PDT by Andy Estes
Modified: 2016-07-27 19:00 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.69 KB, patch)
2016-07-27 17:20 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (5.72 KB, patch)
2016-07-27 17:27 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
Patch (6.86 KB, patch)
2016-07-27 18:14 PDT, Andy Estes
no flags Details | Formatted Diff | Diff
patch for landing (7.03 KB, patch)
2016-07-27 18:29 PDT, Andy Estes
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2016-07-27 17:13:32 PDT
[iOS] Add WKUIDelegate SPI for specifying that an attachment list is from a managed source
Comment 1 Andy Estes 2016-07-27 17:14:39 PDT
<rdar://problem/27471815>
Comment 2 Andy Estes 2016-07-27 17:20:17 PDT
Created attachment 284745 [details]
Patch
Comment 3 Andy Estes 2016-07-27 17:27:26 PDT
Created attachment 284746 [details]
Patch
Comment 4 mitz 2016-07-27 17:56:44 PDT
Comment on attachment 284746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284746&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:75
> +- (BOOL)_attachmentListSourceIsManagedForWebView:(WKWebView *)webView WK_API_AVAILABLE(ios(WK_IOS_TBA));

Instead of adding this and always calling two delegate methods, can you add a new method that returns both the array and the boolean, and only call that (if implemented by the delegate)?
Comment 5 Andy Estes 2016-07-27 18:14:27 PDT
Created attachment 284749 [details]
Patch
Comment 6 mitz 2016-07-27 18:20:06 PDT
Comment on attachment 284749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284749&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:75
> +- (NSArray *)_attachmentListForWebView:(WKWebView *)webView sourceIsManaged:(BOOL *)sourceIsManaged WK_API_AVAILABLE(ios(WK_IOS_TBA));

No space after BOOL.
Comment 7 Andy Estes 2016-07-27 18:29:20 PDT
Created attachment 284751 [details]
patch for landing
Comment 8 WebKit Commit Bot 2016-07-27 19:00:26 PDT
Comment on attachment 284751 [details]
patch for landing

Clearing flags on attachment: 284751

Committed r203809: <http://trac.webkit.org/changeset/203809>
Comment 9 WebKit Commit Bot 2016-07-27 19:00:30 PDT
All reviewed patches have been landed.  Closing bug.