Bug 160236 - [GTK] Remove network setup from web process
Summary: [GTK] Remove network setup from web process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-07-27 00:58 PDT by Carlos Garcia Campos
Modified: 2016-07-27 08:51 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.55 KB, patch)
2016-07-27 00:59 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-07-27 00:58:08 PDT
We are still doing network init and finish in th web process.
Comment 1 Carlos Garcia Campos 2016-07-27 00:59:52 PDT
Created attachment 284680 [details]
Patch
Comment 2 Michael Catanzaro 2016-07-27 06:24:12 PDT
Comment on attachment 284680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284680&action=review

> Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:-63
> -        SoupNetworkSession::defaultSession().setSSLPolicy(SoupNetworkSession::SSLUseSystemCAFile);

OK.

> Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:-71
> -            soup_cache_dump(soupCache);

But as we discussed yesterday, EFL is still using the web process soup cache; I doubt it is safe for them to remove this. We should switch them to use the network cache first (bug #152676).
Comment 3 Carlos Garcia Campos 2016-07-27 06:38:31 PDT
I'm pretty sure EFL doesn't use Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp :-)
Comment 4 Michael Catanzaro 2016-07-27 07:19:09 PDT
Comment on attachment 284680 [details]
Patch

Point
Comment 5 Carlos Garcia Campos 2016-07-27 08:51:20 PDT
Committed r203774: <http://trac.webkit.org/changeset/203774>