Bug 160225 - Disable WebCoreNSURLSessionTest on ios-simulator
Summary: Disable WebCoreNSURLSessionTest on ios-simulator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-26 17:25 PDT by Ryan Haddad
Modified: 2016-07-27 10:17 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2016-07-26 17:31 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch (1.18 KB, patch)
2016-07-26 20:43 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch (1.18 KB, patch)
2016-07-26 22:38 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-07-26 17:25:16 PDT 
Disable API test WebCoreNSURLSessionTest.BasicOperation on ios-simulator
Comment 1 Ryan Haddad 2016-07-26 17:30:25 PDT 
<rdar://problem/26433289>
Comment 2 Ryan Haddad 2016-07-26 17:31:41 PDT 
Created attachment 284657 [details]
Patch
Comment 3 Alexey Proskuryakov 2016-07-26 19:21:12 PDT 
Comment on attachment 284657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284657&action=review

> Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:164
> +#endif
>  
>  TEST_F(WebCoreNSURLSessionTest, InvalidateEmpty)

Is it only the BasicOperation test? I assumed that all WebCoreNSURLSessionTest needed to be disabled.
Comment 4 Ryan Haddad 2016-07-26 20:43:44 PDT 
Created attachment 284670 [details]
Patch

This patch disables all of the WebCoreNSURLSession tests on iOS.
Comment 5 Ryan Haddad 2016-07-26 20:44:55 PDT 
(In reply to comment #3)
> Comment on attachment 284657 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284657&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:164
> > +#endif
> >  
> >  TEST_F(WebCoreNSURLSessionTest, InvalidateEmpty)
> 
> Is it only the BasicOperation test? I assumed that all
> WebCoreNSURLSessionTest needed to be disabled.

This was the only one that asserted, but yes, we may as well disable them all. New patch uploaded.
Comment 6 Alexey Proskuryakov 2016-07-26 22:04:27 PDT 
The new patch breaks Mac build:

/Volumes/Data/EWS/WebKit/Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:139:5: error: unknown type name 'WebCoreNSURLSession'; did you mean 'WebCoreNSURLSessionTest'?
    WebCoreNSURLSession* session = [[WebCoreNSURLSession alloc] initWithResourceLoader:*loader delegate:delegate delegateQueue:[NSOperationQueue mainQueue]];
Comment 7 Ryan Haddad 2016-07-26 22:38:14 PDT 
Created attachment 284675 [details]
Patch

Patch for EWS
Comment 8 Ryan Haddad 2016-07-27 10:17:03 PDT 
Comment on attachment 284675 [details]
Patch

Clearing flags on attachment: 284675

Committed r203781: <http://trac.webkit.org/changeset/203781>
Comment 9 Ryan Haddad 2016-07-27 10:17:07 PDT 
All reviewed patches have been landed.  Closing bug.