Bug 160214 – Align CSSStyleDeclaration with the specification

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Chris Dumez]

Align CSSStyleDeclaration with the specification:
- https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface

In particular, the parameters to removeProperty() / item() / getPropertyPriority() should be mandatory.

Firefox and Chrome match the specification.

[Chris Dumez]

Created attachment 284638 [details]
Patch

[Darin Adler]

Comment on attachment 284638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284638&action=review

> Source/WebCore/css/CSSStyleDeclaration.idl:35
> +    [Custom] CSSValue getPropertyCSSValue(DOMString propertyName);

Shouldn’t the return value be CSSValue? with a question mark so it’s clear it’s nullable?

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 284638 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284638&action=review
> 
> > Source/WebCore/css/CSSStyleDeclaration.idl:35
> > +    [Custom] CSSValue getPropertyCSSValue(DOMString propertyName);
> 
> Shouldn’t the return value be CSSValue? with a question mark so it’s clear
> it’s nullable?

Yes indeed. I'll update.

[Chris Dumez]

Created attachment 284639 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 284639 [details]
Patch

Clearing flags on attachment: 284639

Committed r203744: <http://trac.webkit.org/changeset/203744>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.