Bug 160210 - Parameters to CSSStyleSheet.insertRule() / deleteRule() should be mandatory
Summary: Parameters to CSSStyleSheet.insertRule() / deleteRule() should be mandatory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-26 13:46 PDT by Chris Dumez
Modified: 2016-07-26 15:01 PDT (History)
6 users (show)

See Also:


Attachments
Patch (13.00 KB, patch)
2016-07-26 14:04 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (14.28 KB, patch)
2016-07-26 14:38 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-26 13:46:36 PDT
Parameters to CSSStyleSheet.insertRule() / deleteRule() should be mandatory:
- https://drafts.csswg.org/cssom/#cssstylesheet

They are mandatory in Firefox.
They are mandatory in Chrome except for the second parameter of insertRule() which merely logs a deprecation warning.

I propose to match Chrome's behavior to move towards to specification while limiting the risk of breakage.
Comment 1 Chris Dumez 2016-07-26 14:04:23 PDT
Created attachment 284628 [details]
Patch
Comment 2 Chris Dumez 2016-07-26 14:38:40 PDT
Created attachment 284632 [details]
Patch
Comment 3 Chris Dumez 2016-07-26 15:01:33 PDT
Comment on attachment 284632 [details]
Patch

Clearing flags on attachment: 284632

Committed r203740: <http://trac.webkit.org/changeset/203740>
Comment 4 Chris Dumez 2016-07-26 15:01:37 PDT
All reviewed patches have been landed.  Closing bug.