Bug 160208 - Occasional crash in WebCore::RenderVTTCue::initializeLayoutParameters
Summary: Occasional crash in WebCore::RenderVTTCue::initializeLayoutParameters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-26 13:35 PDT by Eric Carlson
Modified: 2016-07-26 14:36 PDT (History)
4 users (show)

See Also:

Attachments
Proposed patch. (1.24 KB, patch)
2016-07-26 13:43 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-07-26 13:35:57 PDT 
From crash logs, it seems that RenderVTTCue::firstChild is sometimes NULL when it should not be. Debug builds ASSERT when this is true, but release builds should not crash.
Comment 1 Eric Carlson 2016-07-26 13:36:31 PDT 
rdar://problem/21090897
Comment 2 Eric Carlson 2016-07-26 13:43:43 PDT 
Created attachment 284625 [details]
Proposed patch.
Comment 3 Darin Adler 2016-07-26 14:15:13 PDT 
Comment on attachment 284625 [details]
Proposed patch.

OK
Comment 4 WebKit Commit Bot 2016-07-26 14:36:31 PDT 
Comment on attachment 284625 [details]
Proposed patch.

Clearing flags on attachment: 284625

Committed r203737: <http://trac.webkit.org/changeset/203737>
Comment 5 WebKit Commit Bot 2016-07-26 14:36:35 PDT 
All reviewed patches have been landed.  Closing bug.