RenderBox is the only client.
Created attachment 284618 [details] Patch
Comment on attachment 284618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284618&action=review > Source/WebCore/platform/ControlStates.h:102 > + RetainPtr<PlatformControlInstance> m_controlInstance { nullptr }; No need for this. > Source/WebCore/rendering/RenderBox.cpp:113 > +static HashMap<const RenderObject*, std::unique_ptr<ControlStates>>& controlStatesRendererMap() Maybe do a using for HashMap<const RenderObject*, std::unique_ptr<ControlStates>> > Source/WebCore/rendering/RenderBox.cpp:180 > + removeControlStatesForRenderer(*this); Maybe we should use a bit to avoid this hash lookup on every RenderBox dtor.
Created attachment 284629 [details] Patch
Comment on attachment 284629 [details] Patch Clearing flags on attachment: 284629 Committed r203738: <http://trac.webkit.org/changeset/203738>
All reviewed patches have been landed. Closing bug.