WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
160204
Align NamedNodeMap with the specification
https://bugs.webkit.org/show_bug.cgi?id=160204
Summary
Align NamedNodeMap with the specification
Chris Dumez
Reported
2016-07-26 11:30:21 PDT
Align NamedNodeMap with the specification: -
https://dom.spec.whatwg.org/#interface-namednodemap
In particular, mark parameters as mandatory when they should be use use stricter "Attr" typing instead of Node. Chrome and Firefox agree with the specification.
Attachments
Patch
(24.34 KB, patch)
2016-07-26 11:35 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2016-07-26 11:35:00 PDT
Created
attachment 284609
[details]
Patch
Darin Adler
Comment 2
2016-07-26 12:07:04 PDT
Comment on
attachment 284609
[details]
Patch I’m starting to get annoyed with how huge the impact of the Objective-C bindings is on our IDL files and even on the DOM implementation. I think we should consider how to preserve the existing Objective-C bindings with less cost. Sam told me he and Anders have been discussing an approach and Sam’s going to talk to you about it, Chris.
WebKit Commit Bot
Comment 3
2016-07-26 12:11:05 PDT
Comment on
attachment 284609
[details]
Patch Clearing flags on attachment: 284609 Committed
r203731
: <
http://trac.webkit.org/changeset/203731
>
WebKit Commit Bot
Comment 4
2016-07-26 12:11:12 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug