Bug 160204 - Align NamedNodeMap with the specification
Summary: Align NamedNodeMap with the specification
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#interfac...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-26 11:30 PDT by Chris Dumez
Modified: 2016-07-26 12:11 PDT (History)
11 users (show)

See Also:

Attachments
Patch (24.34 KB, patch)
2016-07-26 11:35 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-26 11:30:21 PDT 
Align NamedNodeMap with the specification:
- https://dom.spec.whatwg.org/#interface-namednodemap

In particular, mark parameters as mandatory when they should be use use stricter "Attr" typing instead of Node.

Chrome and Firefox agree with the specification.
Comment 1 Chris Dumez 2016-07-26 11:35:00 PDT 
Created attachment 284609 [details]
Patch
Comment 2 Darin Adler 2016-07-26 12:07:04 PDT 
Comment on attachment 284609 [details]
Patch

I’m starting to get annoyed with how huge the impact of the Objective-C bindings is on our IDL files and even on the DOM implementation. I think we should consider how to preserve the existing Objective-C bindings with less cost. Sam told me he and Anders have been discussing an approach and Sam’s going to talk to you about it, Chris.
Comment 3 WebKit Commit Bot 2016-07-26 12:11:05 PDT 
Comment on attachment 284609 [details]
Patch

Clearing flags on attachment: 284609

Committed r203731: <http://trac.webkit.org/changeset/203731>
Comment 4 WebKit Commit Bot 2016-07-26 12:11:12 PDT 
All reviewed patches have been landed.  Closing bug.