Not a huge deal, just noticed it. Not sure how to test it though.
Created attachment 284587 [details] Patch
Comment on attachment 284587 [details] Patch Clearly a correct change and likely valuable. Antti, Jer, any insight into what the symptom will be here?
> Clearly a correct change and likely valuable. Antti, Jer, any insight into > what the symptom will be here? It could cause inappropriate style sharing (and so wrong style being applied) from the full screen element to some other element. Good find.
(In reply to comment #3) > > Clearly a correct change and likely valuable. Antti, Jer, any insight into > > what the symptom will be here? > > It could cause inappropriate style sharing (and so wrong style being > applied) from the full screen element to some other element. Good find. Sorry, what I meant to say was, can we figure out how to use this information to help us construct a test case?
> Sorry, what I meant to say was, can we figure out how to use this > information to help us construct a test case? It would involve inserting an element that is otherwise identical to the full screen element (in full screen mode) so the style gets copied. This is likely to be somewhat tricky. I assume there is some sort of non-CSS styling in full screen elements that would result in observable differences (since these tests exist).
*** Bug 174147 has been marked as a duplicate of this bug. ***
Comment on attachment 284587 [details] Patch Antti, do you think this is worth landing? I think it is, and I remember spending a fair amount of time trying to test this without success (though I could try again I guess). The ChangeLog entry is suboptimal (heh, was my very first try). I can probably send a new patch if you want.
Comment on attachment 284587 [details] Patch Rejecting attachment 284587 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 284587, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/4055293
Sure, please land it. ChangeLog needs some fixes to get through the commit queue.
Created attachment 314631 [details] Patch
Created attachment 314632 [details] Patch
Comment on attachment 314632 [details] Patch Clearing flags on attachment: 314632 Committed r219147: <http://trac.webkit.org/changeset/219147>
All reviewed patches have been landed. Closing bug.