Bug 160194 – [Streams API] Replace ReadableStreamReader by ReadableStreamDefaultReader

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Romain Bellessort]

Streams API now considers different kinds of readers. To start aligning with spec, ReadableStreamReader should be replaced by ReadableStreamDefaultReader.

[Romain Bellessort]

Created attachment 284585 [details]
Patch

[Romain Bellessort]

Created attachment 284591 [details]
Patch

[youenn fablet]

Comment on attachment 284591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284591&action=review

> Source/WebCore/features.json:681
> +        "comment": "The ReadableStream and ReadableStreamDefaultReader interfaces are available but not functional."

This comment is no longer valid. Also ReadableStreamDefaultReader is NoInterfaceObject.

I would rewrite the comment to something like:
The implementation does not support ReadableStreamBYOBReader.

Also, it might be worth investigating the removal of STREAMS_API for ReadableStream (probably not WritableStream) and add a runtime flag for it.

[Romain Bellessort]

Created attachment 284682 [details]
Patch

[Romain Bellessort]

(In reply to comment #3)
> Comment on attachment 284591 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284591&action=review
> 
> > Source/WebCore/features.json:681
> > +        "comment": "The ReadableStream and ReadableStreamDefaultReader interfaces are available but not functional."
> 
> This comment is no longer valid. Also ReadableStreamDefaultReader is
> NoInterfaceObject.
> 
> I would rewrite the comment to something like:
> The implementation does not support ReadableStreamBYOBReader.

The new patch fixes that and also replaces ReadableStreamReader by ReadableStreamDefaultReader in LayoutTests/streams.

> Also, it might be worth investigating the removal of STREAMS_API for
> ReadableStream (probably not WritableStream) and add a runtime flag for it.

Thanks, I'll try to investigate this.

[youenn fablet]

Comment on attachment 284682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284682&action=review

> Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js:33
> +        return @Promise.@reject(new @TypeError("Can only call ReadableStreamDefaultReader.cancel on instances of ReadableStreamDefaultReader"));

This should use makeThisTypeError. See the latest change to Source/WebCore/Modules/streams/ReadableStreamReader.js
Let's do that as a follow-up patch.
Ditto for other functions.

[WebKit Commit Bot]

Comment on attachment 284682 [details]
Patch

Clearing flags on attachment: 284682

Committed r203772: <http://trac.webkit.org/changeset/203772>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.