Bug 160191 - JS Built-ins should throw this-error messages consistently with binding generated code
Summary: JS Built-ins should throw this-error messages consistently with binding gener...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-26 03:19 PDT by youenn fablet
Modified: 2016-07-26 23:39 PDT (History)
4 users (show)

See Also:


Attachments
Patch (23.42 KB, patch)
2016-07-26 03:32 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-07-26 03:19:46 PDT
When checking "this", the same error message should be used for JS built-ins and binding generated code.
Comment 1 youenn fablet 2016-07-26 03:32:48 PDT
Created attachment 284571 [details]
Patch
Comment 2 WebKit Commit Bot 2016-07-26 03:34:46 PDT
Attachment 284571 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:109:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WebCore/bindings/js/JSDOMGlobalObject.cpp:111:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2016-07-26 23:39:02 PDT
Comment on attachment 284571 [details]
Patch

Clearing flags on attachment: 284571

Committed r203766: <http://trac.webkit.org/changeset/203766>
Comment 4 WebKit Commit Bot 2016-07-26 23:39:06 PDT
All reviewed patches have been landed.  Closing bug.