Regression(r203535): Uncaught Exception: TypeError: Not enough arguments at LayerTreeDataGridNode.js:47

[Benjamin Poulain]

-------
Inspected URL:        http://cookingaddict.net/
Loading completed:    true
Frontend User Agent:  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/603.1.1+ (KHTML, like Gecko)

Uncaught Exceptions:
 - TypeError: Not enough arguments (at LayerTreeDataGridNode.js:47:131)
    createTextNode @ [native code]
    createCellContent @ LayerTreeDataGridNode.js:47:131
    createCell @ DataGridNode.js:361:45
    createCells @ DataGridNode.js:111:54
    createCells @ LayerTreeDataGridNode.js:40:26
    element @ DataGridNode.js:104:25
    _updateVisibleRows @ DataGrid.js:1070:47
    layout @ DataGrid.js:852:32
    _layoutSubtree @ View.js:250:20
    updateLayout @ View.js:147:28
    updateLayoutIfNeeded @ View.js:155:26
    _sortNodesCallback @ DataGrid.js:1344:38
    _sortNodesCallback @ [native code]
-------

* STEPS TO REPRODUCE
1. What were you doing? Include setup or other preparations to reproduce the exception.
2. Include explicit, accurate, and minimal steps taken. Do not include extraneous or irrelevant steps.

* NOTES
Document any additional information that might be useful in resolving the problem, such as screen shots or other included attachments.

[Radar WebKit Bug Importer]

<rdar://problem/27540435>

[Benjamin Poulain]

To reproduce:
-Open http://cookingaddict.net
-Right click on the slider->Inspect
-Click on the div with id="defilhor"

[Chris Dumez]

var cell = columnIdentifier === "name" ? this._makeNameCell() : this._makeOutlet(columnIdentifier, document.createTextNode());

Parameter to createTextNode() is mandatory after:
http://trac.webkit.org/changeset/203535

document.createTextNode() was identical to calling document.createTextNode("undefined") :/

[BJ Burg]

(In reply to comment #3)
> var cell = columnIdentifier === "name" ? this._makeNameCell() :
> this._makeOutlet(columnIdentifier, document.createTextNode());
> 
> Parameter to createTextNode() is mandatory after:
> http://trac.webkit.org/changeset/203535
> 
> document.createTextNode() was identical to calling
> document.createTextNode("undefined") :/

Oops! This is in view code so we didn't have any coverage for that change.

[BJ Burg]

Created attachment 284619 [details]
Proposed Fix

[Nikita Vasilyev]

Comment on attachment 284619 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284619&action=review

Looks good, but I'm not a reviewer to r+ it.

> Source/WebInspectorUI/UserInterface/Views/LayerTreeDataGridNode.js:47
> +        cell = columnIdentifier === "name" ? this._makeNameCell() : this._makeOutlet(columnIdentifier, document.createTextNode("â"));

â is an em dash. Our bugzilla doesn't handle unicode that well, apparently.

[Nikita Vasilyev]

*** Bug 160250 has been marked as a duplicate of this bug. ***

[WebKit Commit Bot]

Comment on attachment 284619 [details]
Proposed Fix

Clearing flags on attachment: 284619

Committed r203778: <http://trac.webkit.org/changeset/203778>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.