Bug 160186 – [iOS] SF-Heavy is inaccessible by web content

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[iOS] SF-Heavy is inaccessible by web content

[Myles C. Maxfield]

<rdar://problem/27434423>

[Myles C. Maxfield]

Created attachment 284564 [details]
Patch

[Build Bot]

Comment on attachment 284564 [details]
Patch

Attachment 284564 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1754784

New failing tests:
fast/text/weighted-italicized-system-font.html

[Build Bot]

Created attachment 284566 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Myles C. Maxfield]

Created attachment 284608 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 284608 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284608&action=review

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:142
> +        // so we should investigate the result <rdar://problem/14449340>:

Remove the comment

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:155
> +static RetainPtr<CFDictionaryRef> systemFontModificationAttributes(FontWeight weight, bool italic)

I wonder if this entire function would be easier to write using Obj-C literals.

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:160
> +    RetainPtr<CFNumberRef> weightNumber = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberFloatType, ctWeights + weight));

Would prefer explicit array indexing. What's to prevent things changing and allowing out of range indexing?

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:164
> +    RetainPtr<CFNumberRef> trueNumber = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, &one));

@1!

[Dean Jackson]

Comment on attachment 284608 [details]
Patch

Do we still have the issue where the normal weight of the system font doesn't match what you'd get if you ask for 400? Can you test that?

[Build Bot]

Comment on attachment 284608 [details]
Patch

Attachment 284608 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1757519

New failing tests:
fast/text/system-font-weight.html

[Build Bot]

Created attachment 284616 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Myles C. Maxfield]

Created attachment 284673 [details]
Patch for committing

[Myles C. Maxfield]

Comment on attachment 284673 [details]
Patch for committing

View in context: https://bugs.webkit.org/attachment.cgi?id=284673&action=review

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:166
> +    return adoptNS(@{ static_cast<NSString *>(kCTFontTraitsAttribute) : traitsDictionary.get() });

This adoptNS is wrong.

[Myles C. Maxfield]

Committed r203764: <http://trac.webkit.org/changeset/203764>