Bug 160179 - AX: Expose autoFillButtonType to accessibility
Summary: AX: Expose autoFillButtonType to accessibility
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-25 17:11 PDT by Nan Wang
Modified: 2016-07-25 22:28 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.97 KB, patch)
2016-07-25 17:14 PDT, Nan Wang 		no flags Details | Formatted Diff | Diff
Patch (6.93 KB, patch)
2016-07-25 17:59 PDT, Nan Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2016-07-25 17:11:14 PDT 
We currently only have function to check if value auto-fill is available. We also need to expose the auto-fill button type so that screen reader can speak the correct hint.

<rdar://problem/27279453>
Comment 1 Nan Wang 2016-07-25 17:14:05 PDT 
Created attachment 284552 [details]
Patch
Comment 2 chris fleizach 2016-07-25 17:47:01 PDT 
Comment on attachment 284552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284552&action=review

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3247
> +            return @"autofillNone";

since the type is already "AXValueAutofillType" the values can probably just be "none", "credentials", "contacts"
Comment 3 Nan Wang 2016-07-25 17:59:58 PDT 
Created attachment 284556 [details]
Patch

Review comments
Comment 4 WebKit Commit Bot 2016-07-25 22:28:39 PDT 
Comment on attachment 284556 [details]
Patch

Clearing flags on attachment: 284556

Committed r203711: <http://trac.webkit.org/changeset/203711>
Comment 5 WebKit Commit Bot 2016-07-25 22:28:43 PDT 
All reviewed patches have been landed.  Closing bug.