Bug 160178 - [iPhone] Playing a video on tudou.com plays only sound, no video
Summary: [iPhone] Playing a video on tudou.com plays only sound, no video
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
: 160176 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-07-25 16:45 PDT by Myles C. Maxfield
Modified: 2016-07-26 16:38 PDT (History)
7 users (show)

See Also:

Attachments
Patch (48.60 KB, patch)
2016-07-25 16:54 PDT, Myles C. Maxfield 		mitz: review+
Details | Formatted Diff | Diff
Patch for committing (48.66 KB, patch)
2016-07-26 11:56 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-07-25 16:45:05 PDT 
[iPhone] Playing a video on tudou.com plays only sound, no video
Comment 1 Myles C. Maxfield 2016-07-25 16:45:31 PDT 
*** Bug 160176 has been marked as a duplicate of this bug. ***
Comment 2 Myles C. Maxfield 2016-07-25 16:54:57 PDT 
Created attachment 284546 [details]
Patch
Comment 3 Myles C. Maxfield 2016-07-25 16:55:41 PDT 
<rdar://problem/27535468>
Comment 4 Eric Carlson 2016-07-26 07:29:41 PDT 
Comment on attachment 284546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284546&action=review

This looks generally fine to me, but you will need to get an official r+ from a WK2 reviewer.

> LayoutTests/media/video-webkit-playsinline.html:22
> +    run('internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(' + requiresPlaysInline + ')');

Nit: I think this would be easier to use if you used a template literal, e.g.: run(`internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(${requiresPlaysInline})`);

> LayoutTests/media/video-webkit-playsinline.html:27
> +    run('video.' + (hasWebkitPlaysInline ? 'set' : 'remove') + 'Attribute("webkit-playsinline", "")');

Ditto: run(`video.${hasWebkitPlaysInline ? 'set' : 'remove'}Attribute("webkit-playsinline", "")`);
Comment 5 Myles C. Maxfield 2016-07-26 11:56:11 PDT 
Created attachment 284612 [details]
Patch for committing
Comment 6 Myles C. Maxfield 2016-07-26 16:38:08 PDT 
Committed r203752: <http://trac.webkit.org/changeset/203752>