Bug 160175 - Cleanup RenderTable*::createAnonymous*
Summary: Cleanup RenderTable*::createAnonymous*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-25 15:34 PDT by zalan
Modified: 2016-07-25 19:41 PDT (History)
5 users (show)

See Also:


Attachments
Patch (23.91 KB, patch)
2016-07-25 15:46 PDT, zalan
simon.fraser: review+
Details | Formatted Diff | Diff
Patch (25.36 KB, patch)
2016-07-25 18:54 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-07-25 15:34:39 PDT
Type tightening + they are somewhat misleading.
Comment 1 zalan 2016-07-25 15:46:47 PDT
Created attachment 284536 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-07-25 15:58:13 PDT
Comment on attachment 284536 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284536&action=review

> Source/WebCore/rendering/RenderTable.cpp:221
> -    section->addChild(child);
> +    section->addChild(section);

Revert this bit.
Comment 3 zalan 2016-07-25 18:54:02 PDT
Created attachment 284559 [details]
Patch
Comment 4 WebKit Commit Bot 2016-07-25 19:41:09 PDT
Comment on attachment 284559 [details]
Patch

Clearing flags on attachment: 284559

Committed r203708: <http://trac.webkit.org/changeset/203708>
Comment 5 WebKit Commit Bot 2016-07-25 19:41:14 PDT
All reviewed patches have been landed.  Closing bug.