Bug 160171 - AssemblyHelpers should own all of the cell allocation methods
Summary: AssemblyHelpers should own all of the cell allocation methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 160125
  Show dependency tree / graph
 
Reported: 2016-07-25 13:11 PDT by Filip Pizlo
Modified: 2016-07-25 14:05 PDT (History)
5 users (show)

See Also:

Attachments
the patch (17.87 KB, patch)
2016-07-25 13:14 PDT, Filip Pizlo 		mark.lam: review-
Details | Formatted Diff | Diff
the patch (17.89 KB, patch)
2016-07-25 13:26 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (17.89 KB, patch)
2016-07-25 13:31 PDT, Filip Pizlo 		saam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-07-25 13:11:17 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-07-25 13:14:08 PDT 
Created attachment 284518 [details]
the patch
Comment 2 Mark Lam 2016-07-25 13:19:16 PDT 
Comment on attachment 284518 [details]
the patch

Please fix the build failures.
Comment 3 Filip Pizlo 2016-07-25 13:26:19 PDT 
Created attachment 284520 [details]
the patch
Comment 4 Filip Pizlo 2016-07-25 13:31:44 PDT 
Created attachment 284521 [details]
the patch
Comment 5 Saam Barati 2016-07-25 13:51:03 PDT 
Comment on attachment 284521 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284521&action=review

LGTM

> Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:176
> +    emitAllocateJSObject(resultReg, allocatorReg, TrustedImmPtr(structure), TrustedImmPtr(0), scratchReg, slowCases);

Style suggestion: Maybe it's worth giving the storage parameter here a temp name.
Comment 6 Filip Pizlo 2016-07-25 14:05:09 PDT 
Landed in https://trac.webkit.org/changeset/203699