[css-grid] grid-auto-flow|row should take a <track-size>+
Created attachment 284471 [details] Patch
Attachment 284471 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSParser.h:246: 'parseGridTrackList' is incorrectly named. It should be named 'protector' or 'protectedTrackListType'. [readability/naming/protected] [4] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 284471 [details] Patch Attachment 284471 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1750408 New failing tests: svg/css/getComputedStyle-basic.xhtml
Created attachment 284473 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 284471 [details] Patch Attachment 284471 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1750410 New failing tests: svg/css/getComputedStyle-basic.xhtml
Created attachment 284474 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 284471 [details] Patch Attachment 284471 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1750424 New failing tests: svg/css/getComputedStyle-basic.xhtml
Created attachment 284475 [details] Archive of layout-test-results from ews115 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-yosemite Platform: Mac OS X 10.10.5
Created attachment 284481 [details] Patch There was 1 test in svg checking the types of the computed style objects
Attachment 284481 [details] did not pass style-queue: ERROR: Source/WebCore/css/CSSParser.h:246: 'parseGridTrackList' is incorrectly named. It should be named 'protector' or 'protectedTrackListType'. [readability/naming/protected] [4] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 284481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284481&action=review > Source/WebCore/css/StyleBuilderConverter.h:1006 > + Vector<GridTrackSize> trackSizes; > + for (auto& currValue : downcast<CSSValueList>(value)) { > + ASSERT(!currValue->isGridLineNamesValue()); > + ASSERT(!currValue->isGridAutoRepeatValue()); > + trackSizes.append(convertGridTrackSize(styleResolver, currValue)); > + } > + return trackSizes; A more efficient idiom would be to call reserveInitialCapacity and then use uncheckedAppend.
Comment on attachment 284481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284481&action=review > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1121 > + return WTFMove(list); Could we update the function to return a Ref<CSSValueList> and stop using WTFMove() here?
Comment on attachment 284481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284481&action=review >> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1121 >> + return WTFMove(list); > > Could we update the function to return a Ref<CSSValueList> and stop using WTFMove() here? Sure >> Source/WebCore/css/StyleBuilderConverter.h:1006 >> + return trackSizes; > > A more efficient idiom would be to call reserveInitialCapacity and then use uncheckedAppend. Indeed, I'll update it before landing
Committed r203716: <http://trac.webkit.org/changeset/203716>