RESOLVED FIXED 160152
Web Inspector: Filtering is broken in the Overview timeline view 
https://bugs.webkit.org/show_bug.cgi?id=160152
Summary Web Inspector: Filtering is broken in the Overview timeline view
Matt Baker
Reported 2016-07-24 18:18:55 PDT
Created attachment 284458 [details] [Image] Incorrect filter results Summary: Filtering is broken in the Overview timeline view. This view uses SourceCodeTimelineDataGridNodes, which don't provide the filterable data returned by Script and Layout grid nodes. Since only the "Name" column is shown, filtering on the the node's displayName should be sufficient. Steps to Reproduce: 1. Record a timeline 2. Goto the Overview timeline view 3. Enter a filter that should match nothing: "zxzxzxzxz" Expected: => No filter results in the grid Actual: => Only Resource grid nodes are filtered out
Attachments
[Image] Incorrect filter results (164.03 KB, image/png)
2016-07-24 18:18 PDT, Matt Baker 		no flags
Details
[Patch] Proposed Fix (1.84 KB, patch)
2016-07-24 18:25 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-07-24 18:19:13 PDT
<rdar://problem/27517481>
Matt Baker
Comment 2 2016-07-24 18:25:40 PDT
Created attachment 284459 [details] [Patch] Proposed Fix
Joseph Pecoraro
Comment 3 2016-07-24 20:22:04 PDT
Comment on attachment 284459 [details] [Patch] Proposed Fix r=me
WebKit Commit Bot
Comment 4 2016-07-24 20:43:54 PDT
Comment on attachment 284459 [details] [Patch] Proposed Fix Clearing flags on attachment: 284459 Committed r203673: <http://trac.webkit.org/changeset/203673>
WebKit Commit Bot
Comment 5 2016-07-24 20:43:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.