Bug 160152 - Web Inspector: Filtering is broken in the Overview timeline view
Summary: Web Inspector: Filtering is broken in the Overview timeline view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-24 18:18 PDT by Matt Baker
Modified: 2016-07-24 20:43 PDT (History)
7 users (show)

See Also:

Attachments
[Image] Incorrect filter results (164.03 KB, image/png)
2016-07-24 18:18 PDT, Matt Baker 		no flags Details
[Patch] Proposed Fix (1.84 KB, patch)
2016-07-24 18:25 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-07-24 18:18:55 PDT 
Created attachment 284458 [details]
[Image] Incorrect filter results

Summary:
Filtering is broken in the Overview timeline view. This view uses SourceCodeTimelineDataGridNodes, which don't provide the filterable data returned by Script and Layout grid nodes. Since only the "Name" column is shown, filtering on the the node's displayName should be sufficient.

Steps to Reproduce:
1. Record a timeline
2. Goto the Overview timeline view
3. Enter a filter that should match nothing: "zxzxzxzxz"
Expected:
  => No filter results in the grid
Actual:
  => Only Resource grid nodes are filtered out
Comment 1 Radar WebKit Bug Importer 2016-07-24 18:19:13 PDT 
<rdar://problem/27517481>
Comment 2 Matt Baker 2016-07-24 18:25:40 PDT 
Created attachment 284459 [details]
[Patch] Proposed Fix
Comment 3 Joseph Pecoraro 2016-07-24 20:22:04 PDT 
Comment on attachment 284459 [details]
[Patch] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2016-07-24 20:43:54 PDT 
Comment on attachment 284459 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 284459

Committed r203673: <http://trac.webkit.org/changeset/203673>
Comment 5 WebKit Commit Bot 2016-07-24 20:43:58 PDT 
All reviewed patches have been landed.  Closing bug.