Bug 160150 - Spilling of constant tmps should make it easier for the spill code optimizer to rematerialize the constant
Summary: Spilling of constant tmps should make it easier for the spill code optimizer ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-24 18:03 PDT by Filip Pizlo
Modified: 2016-08-23 13:47 PDT (History)
5 users (show)

See Also:


Attachments
the patch (4.81 KB, patch)
2016-07-24 18:06 PDT, Filip Pizlo
sam: review+
Details | Formatted Diff | Diff
better patch (5.71 KB, patch)
2016-07-25 10:52 PDT, Filip Pizlo
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-07-24 18:03:36 PDT
When we spill in-place for admitsStack()==true, we prevent rematerialization if that argument doesn't also admit immediates (which it almost certainly won't do).  So, we prevent remat.  We should fix that.
Comment 1 Filip Pizlo 2016-07-24 18:06:28 PDT
Created attachment 284456 [details]
the patch
Comment 2 Filip Pizlo 2016-07-25 10:52:34 PDT
Created attachment 284501 [details]
better patch

Needs to be reviewed again.
Comment 3 Benjamin Poulain 2016-07-25 17:20:34 PDT
Comment on attachment 284501 [details]
better patch

Why not.
Comment 4 Filip Pizlo 2016-08-23 13:47:13 PDT
Finally landed in http://trac.webkit.org/changeset/204857