We should implement something akin to Options::useICStats for property access ICs.
Created attachment 284515 [details] patch
Comment on attachment 284515 [details] patch Any reason why this can't be a runtime option?
Attachment 284515 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:4584: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:4601: Missing spaces around / [whitespace/operators] [3] ERROR: Source/JavaScriptCore/bytecode/CodeBlock.cpp:4605: Missing spaces around / [whitespace/operators] [3] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
landed in: https://trac.webkit.org/changeset/203697
(In reply to comment #2) > Comment on attachment 284515 [details] > patch > > Any reason why this can't be a runtime option? Oops. I landed before I saw your question. A couple of reasons why I made it a compile time flag: 1. It adds a field to MathIC, so we don't want to pay for the memory used by that field if we're not using the option. 2. I want to start adding the dump call in more places along each operationValue<Mul/Add/ect> operation, and I don't want to pay for the branch, even though it will be well predicted.