Bug 160109 - [iOS] Clients should be able to decide if they want secure text entry in a form field
Summary: [iOS] Clients should be able to decide if they want secure text entry in a fo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-22 17:01 PDT by Chelsea Pugh
Modified: 2016-07-22 18:20 PDT (History)
5 users (show)

See Also:

Attachments
Patch for [iOS] Clients should be able to decide if they want secure text entry in a form field (3.30 KB, patch)
2016-07-22 17:18 PDT, Chelsea Pugh 		no flags Details | Formatted Diff | Diff
v2 patch for [iOS] Clients should be able to decide if they want secure text entry in a form field (3.25 KB, patch)
2016-07-22 17:48 PDT, Chelsea Pugh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chelsea Pugh 2016-07-22 17:01:21 PDT 
Clients should be able to decide if they want secure text entry in a form field. Patch soon.
Comment 1 Chelsea Pugh 2016-07-22 17:18:21 PDT 
Created attachment 284389 [details]
Patch for [iOS] Clients should be able to decide if they want secure text entry in a form field
Comment 2 mitz 2016-07-22 17:39:51 PDT 
Comment on attachment 284389 [details]
Patch for [iOS] Clients should be able to decide if they want secure text entry in a form field

View in context: https://bugs.webkit.org/attachment.cgi?id=284389&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKFormInputSession.h:47
> +@property (nonatomic) BOOL shouldUseSecureTextEntry WK_API_AVAILABLE(ios(WK_IOS_TBA));

The name implies that setting the property to NO means that secure text entry won’t be used, but that’s not the case. The property only works in one direction, forcing secure text entry to be used where otherwise it wouldn’t. Maybe a name like “forceSecureTextEntry” would express this better?
Comment 3 Chelsea Pugh 2016-07-22 17:47:36 PDT 
(In reply to comment #2)
> Comment on attachment 284389 [details]
> Patch for [iOS] Clients should be able to decide if they want secure text
> entry in a form field
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284389&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/_WKFormInputSession.h:47
> > +@property (nonatomic) BOOL shouldUseSecureTextEntry WK_API_AVAILABLE(ios(WK_IOS_TBA));
> 
> The name implies that setting the property to NO means that secure text
> entry won’t be used, but that’s not the case. The property only works in one
> direction, forcing secure text entry to be used where otherwise it wouldn’t.
> Maybe a name like “forceSecureTextEntry” would express this better?

Yeah, I think that's a better name.
Comment 4 Chelsea Pugh 2016-07-22 17:48:14 PDT 
Created attachment 284390 [details]
v2 patch for [iOS] Clients should be able to decide if they want secure text entry in a form field
Comment 5 WebKit Commit Bot 2016-07-22 18:20:51 PDT 
Comment on attachment 284390 [details]
v2 patch for [iOS] Clients should be able to decide if they want secure text entry in a form field

Clearing flags on attachment: 284390

Committed r203630: <http://trac.webkit.org/changeset/203630>
Comment 6 WebKit Commit Bot 2016-07-22 18:20:54 PDT 
All reviewed patches have been landed.  Closing bug.