Bug 160109 – [iOS] Clients should be able to decide if they want secure text entry in a form field

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chelsea Pugh]

Clients should be able to decide if they want secure text entry in a form field. Patch soon.

[Chelsea Pugh]

Created attachment 284389 [details]
Patch for [iOS] Clients should be able to decide if they want secure text entry in a form field

Comment on attachment 284389 [details]
Patch for [iOS] Clients should be able to decide if they want secure text entry in a form field

View in context: https://bugs.webkit.org/attachment.cgi?id=284389&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKFormInputSession.h:47
> +@property (nonatomic) BOOL shouldUseSecureTextEntry WK_API_AVAILABLE(ios(WK_IOS_TBA));

The name implies that setting the property to NO means that secure text entry won’t be used, but that’s not the case. The property only works in one direction, forcing secure text entry to be used where otherwise it wouldn’t. Maybe a name like “forceSecureTextEntry” would express this better?

[Chelsea Pugh]

(In reply to comment #2)
> Comment on attachment 284389 [details]
> Patch for [iOS] Clients should be able to decide if they want secure text
> entry in a form field
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284389&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/_WKFormInputSession.h:47
> > +@property (nonatomic) BOOL shouldUseSecureTextEntry WK_API_AVAILABLE(ios(WK_IOS_TBA));
> 
> The name implies that setting the property to NO means that secure text
> entry won’t be used, but that’s not the case. The property only works in one
> direction, forcing secure text entry to be used where otherwise it wouldn’t.
> Maybe a name like “forceSecureTextEntry” would express this better?

Yeah, I think that's a better name.

[Chelsea Pugh]

Created attachment 284390 [details]
v2 patch for [iOS] Clients should be able to decide if they want secure text entry in a form field

[WebKit Commit Bot]

Comment on attachment 284390 [details]
v2 patch for [iOS] Clients should be able to decide if they want secure text entry in a form field

Clearing flags on attachment: 284390

Committed r203630: <http://trac.webkit.org/changeset/203630>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.