RESOLVED FIXED 160093
Web Inspector: Hiding a column which contains a TimelineRuler as the headerview, doesn't hide the headerView 
https://bugs.webkit.org/show_bug.cgi?id=160093
Summary Web Inspector: Hiding a column which contains a TimelineRuler as the headervi...
Johan K. Jensen
Reported 2016-07-22 12:40:05 PDT
Summary: Hiding a column (in a DataGrid) which contains a TimelineRuler as the headerview, doesn't hide the TimelineRuler when the column gets hidden. (This is the case for the patch in 160061)
Attachments
[Patch] Proposed Fix (1.79 KB, patch)
2016-07-22 12:56 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-07-22 12:40:18 PDT
<rdar://problem/27499300>
Matt Baker
Comment 2 2016-07-22 12:48:14 PDT
This doesn't affect any grids yet, but will become an issue once the Network waterfall column exists. The bug can still be reproduced, by making a small change to OverviewTimelineView: 1. Add the following to OverviewTimelineView's constructor: this._dataGrid.columnChooserEnabled = true; 2. Right click the grid header 3. Uncheck the "undefined" column => Graph column is hidden but ruler is still visible
Matt Baker
Comment 3 2016-07-22 12:56:04 PDT
Created attachment 284363 [details] [Patch] Proposed Fix
Joseph Pecoraro
Comment 4 2016-07-28 13:46:44 PDT
Comment on attachment 284363 [details] [Patch] Proposed Fix r=me
WebKit Commit Bot
Comment 5 2016-07-28 14:53:05 PDT
Comment on attachment 284363 [details] [Patch] Proposed Fix Clearing flags on attachment: 284363 Committed r203844: <http://trac.webkit.org/changeset/203844>
WebKit Commit Bot
Comment 6 2016-07-28 14:53:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.