Bug 160093 - Web Inspector: Hiding a column which contains a TimelineRuler as the headerview, doesn't hide the headerView
Summary: Web Inspector: Hiding a column which contains a TimelineRuler as the headervi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-22 12:40 PDT by Johan K. Jensen
Modified: 2016-07-28 14:53 PDT (History)
7 users (show)

See Also:

Attachments
[Patch] Proposed Fix (1.79 KB, patch)
2016-07-22 12:56 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Johan K. Jensen 2016-07-22 12:40:05 PDT 
Summary:
Hiding a column (in a DataGrid) which contains a TimelineRuler as the headerview, doesn't hide the TimelineRuler when the column gets hidden. (This is the case for the patch in 160061)
Comment 1 Radar WebKit Bug Importer 2016-07-22 12:40:18 PDT 
<rdar://problem/27499300>
Comment 2 Matt Baker 2016-07-22 12:48:14 PDT 
This doesn't affect any grids yet, but will become an issue once the Network waterfall column exists. The bug can still be reproduced, by making a small change to OverviewTimelineView:

1. Add the following to OverviewTimelineView's constructor:
   this._dataGrid.columnChooserEnabled = true;
2. Right click the grid header
3. Uncheck the "undefined" column
  => Graph column is hidden but ruler is still visible
Comment 3 Matt Baker 2016-07-22 12:56:04 PDT 
Created attachment 284363 [details]
[Patch] Proposed Fix
Comment 4 Joseph Pecoraro 2016-07-28 13:46:44 PDT 
Comment on attachment 284363 [details]
[Patch] Proposed Fix

r=me
Comment 5 WebKit Commit Bot 2016-07-28 14:53:05 PDT 
Comment on attachment 284363 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 284363

Committed r203844: <http://trac.webkit.org/changeset/203844>
Comment 6 WebKit Commit Bot 2016-07-28 14:53:09 PDT 
All reviewed patches have been landed.  Closing bug.