Fix default parameter values for window.alert() / prompt() / confirm() to match the specification: - https://html.spec.whatwg.org/multipage/browsers.html#the-window-object They should default to the empty string, not the string "undefined". Firefox and chrome agree with the specification.
Created attachment 284343 [details] Patch
Comment on attachment 284343 [details] Patch Looks like the GTK build failure is real.
Created attachment 284360 [details] Patch
GTK is now building properly.
Comment on attachment 284360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284360&action=review > Source/WebCore/page/DOMWindow.idl:79 > +#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT > + void alert(); > +#endif > + void alert(DOMString message); Doesn't this break Objective-C bindings when alert is called without an argument?
(In reply to comment #5) > Comment on attachment 284360 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284360&action=review > > > Source/WebCore/page/DOMWindow.idl:79 > > +#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT > > + void alert(); > > +#endif > > + void alert(DOMString message); > > Doesn't this break Objective-C bindings when alert is called without an > argument? We had this discussion on another bug already. optional has no impact on ObjC bindings, so no.
Comment on attachment 284360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284360&action=review >>> Source/WebCore/page/DOMWindow.idl:79 >>> + void alert(DOMString message); >> >> Doesn't this break Objective-C bindings when alert is called without an argument? > > We had this discussion on another bug already. optional has no impact on ObjC bindings, so no. Okay. I didn't see your reply. I guess someone else reviewed it?
(In reply to comment #7) > Comment on attachment 284360 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284360&action=review > > >>> Source/WebCore/page/DOMWindow.idl:79 > >>> + void alert(DOMString message); > >> > >> Doesn't this break Objective-C bindings when alert is called without an argument? > > > > We had this discussion on another bug already. optional has no impact on ObjC bindings, so no. > > Okay. I didn't see your reply. I guess someone else reviewed it? I am referring to https://bugs.webkit.org/show_bug.cgi?id=160060#c3
Comment on attachment 284360 [details] Patch Clearing flags on attachment: 284360 Committed r203612: <http://trac.webkit.org/changeset/203612>
All reviewed patches have been landed. Closing bug.