Bug 160059 – Make parameters mandatory for attribute-related API on Element

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Make parameters mandatory for attribute-related API on Element to match the specification:
- https://dom.spec.whatwg.org/#element

Firefox and Chrome agree with the specification. Calling this API without the parameters does not make much sense, especially considering WebKit uses the string "undefined" when the parameter is omitted.

[Chris Dumez]

Created attachment 284283 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 284283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284283&action=review

> Source/WebCore/dom/Element.idl:39
> +    Attr getAttributeNode(DOMString name);

Why isn't this `Attr?` as in the spec?

[Build Bot]

Comment on attachment 284283 [details]
Patch

Attachment 284283 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1728927

New failing tests:
fast/dom/HTMLAnchorElement/anchor-nodownload-set.html

[Build Bot]

Created attachment 284290 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Chris Dumez]

Comment on attachment 284283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284283&action=review

>> Source/WebCore/dom/Element.idl:39
>> +    Attr getAttributeNode(DOMString name);
> 
> Why isn't this `Attr?` as in the spec?

It has no effect but I will fix for clarity and to match the spec.

[Chris Dumez]

Created attachment 284296 [details]
Patch

[Chris Dumez]

Comment on attachment 284296 [details]
Patch

Clearing flags on attachment: 284296

Committed r203546: <http://trac.webkit.org/changeset/203546>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.