WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
160054
Web Inspector: Console log counter on the dashboard should be better at displaying large numbers
https://bugs.webkit.org/show_bug.cgi?id=160054
Summary
Web Inspector: Console log counter on the dashboard should be better at displ...
Nikita Vasilyev
Reported
2016-07-21 15:33:03 PDT
Created
attachment 284271
[details]
[Image] Current behavior When there are >=1000 messages in the console, it is always shown as "999+". Instead, we should show: 2000 as 2k 2500 as 2.5k 2542 as 2.5k 1000000 as 1m
Attachments
[Image] Current behavior
(14.58 KB, image/png)
2016-07-21 15:33 PDT
,
Nikita Vasilyev
no flags
Details
Patch
(2.22 KB, patch)
2016-08-18 23:09 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(3.06 KB, patch)
2016-08-19 09:18 PDT
,
Devin Rousso
mattbaker
: review+
Details
Formatted Diff
Diff
Patch
(3.96 KB, patch)
2016-08-19 11:10 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2016-07-21 15:33:30 PDT
<
rdar://problem/27481266
>
Devin Rousso
Comment 2
2016-08-18 23:09:13 PDT
Created
attachment 286441
[details]
Patch
Matt Baker
Comment 3
2016-08-19 01:26:25 PDT
Comment on
attachment 286441
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=286441&action=review
This could be a utility function, like Number.bytesToString: Object.defineProperty(Number, "abbreviate", { ... });
> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:104 > + return `${Math.round(number / 100) / 10}k`;
I think uppercase K, M, and B are more common. Although these pseudo-standard metric abbreviations are widely used, they should be UIStrings to allow localization.
> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:109 > + return `${Math.round(number / 100000000) / 10}b`;
That's a lot of console messages!
Devin Rousso
Comment 4
2016-08-19 09:18:05 PDT
Created
attachment 286455
[details]
Patch
Matt Baker
Comment 5
2016-08-19 11:05:18 PDT
Comment on
attachment 286455
[details]
Patch r=me Let's remove _formatPossibleLargeNumber and just call Number.abbreviate directly in the two places it's used.
Devin Rousso
Comment 6
2016-08-19 11:10:48 PDT
Created
attachment 286463
[details]
Patch
WebKit Commit Bot
Comment 7
2016-08-19 11:42:46 PDT
Comment on
attachment 286463
[details]
Patch Clearing flags on attachment: 286463 Committed
r204642
: <
http://trac.webkit.org/changeset/204642
>
WebKit Commit Bot
Comment 8
2016-08-19 11:42:50 PDT
All reviewed patches have been landed. Closing bug.
Nikita Vasilyev
Comment 9
2016-08-19 14:04:04 PDT
Comment on
attachment 286463
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=286463&action=review
Looks good!
> Source/WebInspectorUI/UserInterface/Base/Utilities.js:1047 > + return WebInspector.UIString("%.1fK").format(Math.round(num / 100) / 10);
1000 is shown as "1.0K" and not "1K". It's better in the case when the counter changes and the width stays the same.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug