Bug 160050 - Make parameters to Document.getElementsBy*() operations mandatory
Summary: Make parameters to Document.getElementsBy*() operations mandatory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#interfac...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-21 14:38 PDT by Chris Dumez
Modified: 2016-07-21 16:53 PDT (History)
10 users (show)

See Also:

Attachments
Patch (24.86 KB, patch)
2016-07-21 16:04 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-21 14:38:12 PDT 
Make parameters to Document.getElementsBy*() operations mandatory to match the specification:
- https://dom.spec.whatwg.org/#interface-document

Firefox and Chrome agree with the specification so the compatibility risk should be low.

It makes very little sense to call these operations without parameter, especially considering WebKit uses the string "undefined" if the parameter is omitted.
Comment 1 Chris Dumez 2016-07-21 16:04:40 PDT 
Created attachment 284276 [details]
Patch
Comment 2 WebKit Commit Bot 2016-07-21 16:53:34 PDT 
Comment on attachment 284276 [details]
Patch

Clearing flags on attachment: 284276

Committed r203539: <http://trac.webkit.org/changeset/203539>
Comment 3 WebKit Commit Bot 2016-07-21 16:53:39 PDT 
All reviewed patches have been landed.  Closing bug.