RESOLVED FIXED 160049
Web Inspector: Remove unused code from Debounce layout test 
https://bugs.webkit.org/show_bug.cgi?id=160049
Summary Web Inspector: Remove unused code from Debounce layout test
Matt Baker
Reported 2016-07-21 14:28:23 PDT
The Cancel Debounce test case doesn't need to use callCount or startTime.
Attachments
[Patch] Proposed Fix (1.91 KB, patch)
2016-07-21 14:32 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
[Patch] For Landing (5.05 KB, patch)
2016-07-22 13:07 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-07-21 14:28:48 PDT
<rdar://problem/27479713>
Radar WebKit Bug Importer
Comment 2 2016-07-21 14:29:08 PDT
<rdar://problem/27479718>
Matt Baker
Comment 3 2016-07-21 14:32:58 PDT
Created attachment 284261 [details] [Patch] Proposed Fix
Joseph Pecoraro
Comment 4 2016-07-21 20:11:19 PDT
Comment on attachment 284261 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=284261&action=review r=me! I could swear I had these review comments on the original! > LayoutTests/inspector/unit-tests/debounce.html:132 > - object.debounce(100).test(1, 'xyz'); > + object.debounce(100).test(); > object.test.cancelDebounce(); > > setTimeout(() => { InspectorTest.pass("Debounced function canceled."); resolve(); }, 200); It would be great to reduce these timeouts. 100 and 200 are very high for tests which typically run in 1-2 ms outside of LayoutTests/inspector. Want to change them to like 10 and 50?
Matt Baker
Comment 5 2016-07-22 13:07:29 PDT
Created attachment 284365 [details] [Patch] For Landing
WebKit Commit Bot
Comment 6 2016-07-22 13:37:31 PDT
Comment on attachment 284365 [details] [Patch] For Landing Clearing flags on attachment: 284365 Committed r203614: <http://trac.webkit.org/changeset/203614>
WebKit Commit Bot
Comment 7 2016-07-22 13:37:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.