Bug 160049 - Web Inspector: Remove unused code from Debounce layout test
Summary: Web Inspector: Remove unused code from Debounce layout test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P5 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-21 14:28 PDT by Matt Baker
Modified: 2016-07-22 13:37 PDT (History)
7 users (show)

See Also:


Attachments
[Patch] Proposed Fix (1.91 KB, patch)
2016-07-21 14:32 PDT, Matt Baker
no flags Details | Formatted Diff | Diff
[Patch] For Landing (5.05 KB, patch)
2016-07-22 13:07 PDT, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-07-21 14:28:23 PDT
The Cancel Debounce test case doesn't need to use callCount or startTime.
Comment 1 Radar WebKit Bug Importer 2016-07-21 14:28:48 PDT
<rdar://problem/27479713>
Comment 2 Radar WebKit Bug Importer 2016-07-21 14:29:08 PDT
<rdar://problem/27479718>
Comment 3 Matt Baker 2016-07-21 14:32:58 PDT
Created attachment 284261 [details]
[Patch] Proposed Fix
Comment 4 Joseph Pecoraro 2016-07-21 20:11:19 PDT
Comment on attachment 284261 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284261&action=review

r=me! I could swear I had these review comments on the original!

> LayoutTests/inspector/unit-tests/debounce.html:132
> -            object.debounce(100).test(1, 'xyz');
> +            object.debounce(100).test();
>              object.test.cancelDebounce();
>  
>              setTimeout(() => { InspectorTest.pass("Debounced function canceled."); resolve(); }, 200);

It would be great to reduce these timeouts. 100 and 200 are very high for tests which typically run in 1-2 ms outside of LayoutTests/inspector.

Want to change them to like 10 and 50?
Comment 5 Matt Baker 2016-07-22 13:07:29 PDT
Created attachment 284365 [details]
[Patch] For Landing
Comment 6 WebKit Commit Bot 2016-07-22 13:37:31 PDT
Comment on attachment 284365 [details]
[Patch] For Landing

Clearing flags on attachment: 284365

Committed r203614: <http://trac.webkit.org/changeset/203614>
Comment 7 WebKit Commit Bot 2016-07-22 13:37:35 PDT
All reviewed patches have been landed.  Closing bug.