Ryosuke wrote: "Objective-C bindings files may fail to re-generate after https://trac.webkit.org/changeset/203337. Simply trigger clean rebuilds or delete files under DerivedSources/WebCore/ and it should go away." I hit this myself when moving past r203337. I think we have a bad dependency somewhere. Let's investigate in this bug.
Ryosuke’s theory was that the binding generator doesn't re-generate .cpp files when CodeGeneratorJS.pm is modified (even though that dependency is explicitly expressed in DerivedSources.make). The best way to test this is to do a build, then do another to check that nothing rebuilds (sort of a "baseline"), then touch CodeGeneratorJS.pm, and see what rebuilds. If too little rebuilds, then we could change things so make is invoked with "-d" and see why the rule that is supposed to trigger rebuilds isn’t working.
(In reply to comment #1) > Ryosuke’s theory was that the binding generator doesn't re-generate .cpp > files when CodeGeneratorJS.pm is modified (even though that dependency is > explicitly expressed in DerivedSources.make). > > The best way to test this is to do a build, then do another to check that > nothing rebuilds (sort of a "baseline"), then touch CodeGeneratorJS.pm, and > see what rebuilds. > > If too little rebuilds, then we could change things so make is invoked with > "-d" and see why the rule that is supposed to trigger rebuilds isn’t working. I am going to kick off a build and see if I can repro this particular case again.
(In reply to comment #1) > Ryosuke’s theory was that the binding generator doesn't re-generate .cpp > files when CodeGeneratorJS.pm is modified (even though that dependency is > explicitly expressed in DerivedSources.make). I believe the relevant Make target is for the output .h files. These are a proxy for the .cpp/.mm files. GENERATE_SCRIPTS = \ bindings/scripts/CodeGenerator.pm \ bindings/scripts/IDLParser.pm \ bindings/scripts/generate-bindings.pl \ bindings/scripts/preprocessor.pm JS_BINDINGS_SCRIPTS = $(GENERATE_SCRIPTS) bindings/scripts/CodeGeneratorJS.pm JS%.h : %.idl $(JS_BINDINGS_SCRIPTS) $(IDL_ATTRIBUTES_FILE) $(WINDOW_CONSTRUCTORS_FILE) $(WORKERGLOBALSCOPE_CONSTRUCTORS_FILE) $(PLATFORM_FEATURE_DEFINES) $(call generator_script, $(JS_BINDINGS_SCRIPTS)) $(IDL_COMMON_ARGS) --defines "$(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT" --generator JS --idlAttributesFile $(IDL_ATTRIBUTES_FILE) --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) $<
The build is still going, but my hunch is that we are missing $(WEBCORE) prefixes from some bindings files.
Validating a fix.
Created attachment 284269 [details] Proposed Fix
Comment on attachment 284269 [details] Proposed Fix Clearing flags on attachment: 284269 Committed r203549: <http://trac.webkit.org/changeset/203549>
All reviewed patches have been landed. Closing bug.