https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLVideoElement.idl?rev=202660#L36 shows a "playsinline" IDL attribute (lowercase "i"). However, per spec it should be "playsInline" (uppercase "i"): https://html.spec.whatwg.org/multipage/embedded-content.html#the-video-element:dom-video-playsinline https://html.spec.whatwg.org/multipage/embedded-content.html#dom-video-playsinline
Jer / Eric, what do you think? Can we simply fix the case or do we need to support both now? I checked Firefox and Chrome but neither seems to implement this IDL attribute.
It was added 3 weeks ago so I am hopeful it can still be changed.
We can fix the case since it's new.
<rdar://problem/27474031>
Created attachment 284226 [details] Patch
Thanks for letting us know Domenic!
Comment on attachment 284226 [details] Patch Clearing flags on attachment: 284226 Committed r203511: <http://trac.webkit.org/changeset/203511>
All reviewed patches have been landed. Closing bug.
Comment on attachment 284226 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284226&action=review > Source/WebCore/html/HTMLVideoElement.idl:36 > + [Reflect=playsinline] attribute boolean playsInline; I’m pretty sure that Reflect already lowercases the attribute name to construct the name of the content attribute, so this "=playsinline" part is not needed.
Yes, it’s lowercased in this line of code: $contentAttributeName = lc $generator->AttributeNameForGetterAndSetter($attribute) if $contentAttributeName eq "VALUE_IS_MISSING"; Note the "lc".
(In reply to comment #10) > Yes, it’s lowercased in this line of code: > > $contentAttributeName = lc > $generator->AttributeNameForGetterAndSetter($attribute) if > $contentAttributeName eq "VALUE_IS_MISSING"; > > Note the "lc". I did not know that, thanks for pointing this out. I will upload a patch to fix it.