Bug 160026 - Drop [TreatNullAs=EmptyString] from CanvasRenderingContext2D.globalCompositeOperation
Summary: Drop [TreatNullAs=EmptyString] from CanvasRenderingContext2D.globalCompositeO...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/multipag...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-21 09:34 PDT by Chris Dumez
Modified: 2016-07-21 10:21 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.95 KB, patch)
2016-07-21 09:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.26 KB, patch)
2016-07-21 09:40 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-21 09:34:53 PDT 
Drop [TreatNullAs=EmptyString] from CanvasRenderingContext2D.globalCompositeOperation attribute as it does not match the specification:
- https://html.spec.whatwg.org/multipage/scripting.html#canvascompositing

It does not change behavior because assigning to "" or "null" gets ignored as those are not valid operations.
Comment 1 Chris Dumez 2016-07-21 09:37:10 PDT 
Created attachment 284220 [details]
Patch
Comment 2 Chris Dumez 2016-07-21 09:40:42 PDT 
Created attachment 284221 [details]
Patch
Comment 3 WebKit Commit Bot 2016-07-21 10:21:43 PDT 
Comment on attachment 284221 [details]
Patch

Clearing flags on attachment: 284221

Committed r203510: <http://trac.webkit.org/changeset/203510>
Comment 4 WebKit Commit Bot 2016-07-21 10:21:48 PDT 
All reviewed patches have been landed.  Closing bug.