Bug 160025 - Fix null handling of SVGAngle/SVGLength.valueAsString attribute
Summary: Fix null handling of SVGAngle/SVGLength.valueAsString attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-21 08:50 PDT by Chris Dumez
Modified: 2016-07-21 14:32 PDT (History)
8 users (show)

See Also:

Attachments
Patch (9.08 KB, patch)
2016-07-21 10:09 PDT, Chris Dumez 		rniwa: review+
rniwa: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-21 08:50:52 PDT 
Fix null handling of SVGAngle.valueAsString attribute to match the specification:
- https://www.w3.org/TR/SVG/types.html#__svg__SVGAngle__valueAsString
- https://www.w3.org/TR/SVG2/types.html#InterfaceSVGAngle

We should not treat null as the empty String.
Comment 1 Chris Dumez 2016-07-21 10:09:22 PDT 
Created attachment 284223 [details]
Patch
Comment 2 Ryosuke Niwa 2016-07-21 14:30:10 PDT 
Comment on attachment 284223 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284223&action=review

> Source/WebCore/ChangeLog:21
> +        instead of being ignored. The compatbility risk should be

Nit: *compatibility*.
Comment 3 Chris Dumez 2016-07-21 14:32:17 PDT 
Committed r203531: <http://trac.webkit.org/changeset/203531>