Bug 159997 - Fix null handling of several Document attributes
Summary: Fix null handling of several Document attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/multipag...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-20 16:36 PDT by Chris Dumez
Modified: 2016-07-20 20:31 PDT (History)
9 users (show)

See Also:


Attachments
Patch (7.90 KB, patch)
2016-07-20 18:44 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.90 KB, patch)
2016-07-20 18:46 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-20 16:36:48 PDT
Fix null handlin of the following Document attributes: title, cookie and domain.

In WebKit, they are all marked as [TreatNullAs=EmptyString], which does not match the specification:
- https://html.spec.whatwg.org/multipage/dom.html#document

null is supposed to be treated as the string "null".
Comment 1 Chris Dumez 2016-07-20 18:44:46 PDT
Created attachment 284179 [details]
Patch
Comment 2 Chris Dumez 2016-07-20 18:46:04 PDT
Created attachment 284180 [details]
Patch
Comment 3 WebKit Commit Bot 2016-07-20 20:31:46 PDT
Comment on attachment 284180 [details]
Patch

Clearing flags on attachment: 284180

Committed r203487: <http://trac.webkit.org/changeset/203487>
Comment 4 WebKit Commit Bot 2016-07-20 20:31:53 PDT
All reviewed patches have been landed.  Closing bug.