Bug 159991 – Kill legacy valueToStringWithNullCheck() utility function

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Kill legacy valueToStringWithNullCheck() utility function. Treating null as a null string is legacy behavior so drop this function so that people are not tempted to use it. We should be using either:
1. JSValue::toWTFString() for non-nullable DOMStrings
2. valueToStringWithUndefinedOrNullCheck() for nullable DOMStrings
3. valueToStringTreatingNullAsEmptyString() for strings with [TreatNullAs=EmptyString]

[Chris Dumez]

Created attachment 284165 [details]
Patch

[Chris Dumez]

Comment on attachment 284165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284165&action=review

> Source/WebCore/bindings/js/JSHTMLFrameElementCustom.cpp:57
> +    String locationValue = value.isNull() ? String() : value.toWTFString(&state);

I maintained the previous behavior for this setter (treating null as the null String) even though this behavior is non-standard since the attribute is non-standard. It was never implemented in Firefox / IE and Chrome dropped it a while back after getting usage data showing this was barely used.
I personally think we should try and drop this attribute as well but I did not want to do this in this patch.

[Chris Dumez]

Comment on attachment 284165 [details]
Patch

Clearing flags on attachment: 284165

Committed r203516: <http://trac.webkit.org/changeset/203516>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.