RESOLVED FIXED 159987
Fix null handling of HTMLFrameElement.marginWidth / marginHeight 
https://bugs.webkit.org/show_bug.cgi?id=159987
Summary Fix null handling of HTMLFrameElement.marginWidth / marginHeight
Chris Dumez
Reported 2016-07-20 14:26:34 PDT
Fix null handling of HTMLFrameElement.marginWidth / marginHeight: - https://html.spec.whatwg.org/multipage/obsolete.html#htmlframeelement We are supposed to treat null as the empty string but we treat it as the string "null". Firefox and Chrome both match the specification.
Attachments
Patch (4.69 KB, patch)
2016-07-20 15:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-yosemite (810.36 KB, application/zip)
2016-07-20 16:00 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (868.17 KB, application/zip)
2016-07-20 16:03 PDT, Build Bot 		no flags
Details
Patch (7.53 KB, patch)
2016-07-20 16:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-20 15:11:06 PDT
Created attachment 284152 [details] Patch
Build Bot
Comment 2 2016-07-20 16:00:08 PDT
Comment on attachment 284152 [details] Patch Attachment 284152 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1717552 New failing tests: imported/w3c/web-platform-tests/html/dom/reflection-obsolete.html
Build Bot
Comment 3 2016-07-20 16:00:12 PDT
Created attachment 284160 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Chris Dumez
Comment 4 2016-07-20 16:03:12 PDT
There are new PASSes in imported/w3c/web-platform-tests/html/dom/reflection-obsolete.html, I'll rebaseline before landing.
Build Bot
Comment 5 2016-07-20 16:03:40 PDT
Comment on attachment 284152 [details] Patch Attachment 284152 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1717554 New failing tests: imported/w3c/web-platform-tests/html/dom/reflection-obsolete.html
Build Bot
Comment 6 2016-07-20 16:03:45 PDT
Created attachment 284161 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Chris Dumez
Comment 7 2016-07-20 16:06:17 PDT
Created attachment 284163 [details] Patch
Chris Dumez
Comment 8 2016-07-20 16:07:33 PDT
Committed r203474: <http://trac.webkit.org/changeset/203474>
Note You need to log in before you can comment on or make changes to this bug.