WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
159981
REGRESSION (
r202927
): The internal size of the ImageBuffer is scaled twice by the context scaleFactor
https://bugs.webkit.org/show_bug.cgi?id=159981
Summary
REGRESSION (r202927): The internal size of the ImageBuffer is scaled twice by...
Said Abou-Hallawa
Reported
2016-07-20 11:42:26 PDT
This causes the scaled PDF image to be blurred and have lower resolution than what normal PDF can render for low scale graphics context.
Attachments
Test case and its expected rendering
(14.11 KB, application/zip)
2016-07-20 11:45 PDT
,
Said Abou-Hallawa
no flags
Details
Screenshot for the test case and the expected rendering
(52.71 KB, image/png)
2016-07-20 11:47 PDT
,
Said Abou-Hallawa
no flags
Details
Patch
(46.94 KB, patch)
2016-07-21 16:59 PDT
,
Dean Jackson
mmaxfield
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1
2016-07-20 11:45:13 PDT
Created
attachment 284133
[details]
Test case and its expected rendering The expected page renders the PDF as expected with this regression.
Said Abou-Hallawa
Comment 2
2016-07-20 11:47:48 PDT
Created
attachment 284135
[details]
Screenshot for the test case and the expected rendering
Said Abou-Hallawa
Comment 3
2016-07-20 11:49:04 PDT
<
rdar://problem/27429465
>
Dean Jackson
Comment 4
2016-07-21 16:59:01 PDT
Created
attachment 284284
[details]
Patch
Myles C. Maxfield
Comment 5
2016-07-21 17:18:41 PDT
Comment on
attachment 284284
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=284284&action=review
> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:102 > + std::unique_ptr<ImageBuffer> buffer(new ImageBuffer(scaledSize, 1, colorSpace.get(), renderingMode, success));
make_unique
Dean Jackson
Comment 6
2016-07-21 17:50:46 PDT
Committed
r203543
: <
http://trac.webkit.org/changeset/203543
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug