Bug 159966 - Mark overriden methods in WebCore/svg final classes as final
Summary: Mark overriden methods in WebCore/svg final classes as final
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rawinder Singh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-20 01:12 PDT by Rawinder Singh
Modified: 2016-07-20 14:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (102.78 KB, patch)
2016-07-20 01:18 PDT, Rawinder Singh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rawinder Singh 2016-07-20 01:12:49 PDT 
Update WebCore/svg classes so that overriden methods in final classes are marked final.
Comment 1 Rawinder Singh 2016-07-20 01:18:25 PDT 
Created attachment 284092 [details]
Patch
Comment 2 Michael Catanzaro 2016-07-20 14:00:56 PDT 
Comment on attachment 284092 [details]
Patch

I really prefer the override keyword; the semantics are identical in a final class, and override is more clear. But this is what the style guide says to do, so guess I'd better get used to it.
Comment 3 WebKit Commit Bot 2016-07-20 14:22:19 PDT 
Comment on attachment 284092 [details]
Patch

Clearing flags on attachment: 284092

Committed r203469: <http://trac.webkit.org/changeset/203469>
Comment 4 WebKit Commit Bot 2016-07-20 14:22:23 PDT 
All reviewed patches have been landed.  Closing bug.