Bug 159960 - Use getElementById for attribute matching if the attribute name is html's id
Summary: Use getElementById for attribute matching if the attribute name is html's id
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-19 16:45 PDT by Benjamin Poulain
Modified: 2016-07-19 18:30 PDT (History)
5 users (show)

See Also:


Attachments
Patch (25.19 KB, patch)
2016-07-19 16:53 PDT, Benjamin Poulain
cdumez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-07-19 16:45:52 PDT
Use getElementById for attribute matching if the attribute name is html's id
Comment 1 Benjamin Poulain 2016-07-19 16:53:17 PDT
Created attachment 284071 [details]
Patch
Comment 2 Chris Dumez 2016-07-19 16:58:41 PDT
Comment on attachment 284071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284071&action=review

> Source/WebCore/dom/SelectorQuery.h:113
> +    AtomicString m_idFilter;

Where is this used?
Comment 3 Chris Dumez 2016-07-19 17:02:46 PDT
Comment on attachment 284071 [details]
Patch

r=me
Comment 4 Benjamin Poulain 2016-07-19 18:30:20 PDT
Committed r203439: <http://trac.webkit.org/changeset/203439>