Bug 159952 - REGRESSION(r203415): ASSERTION FAILED: !m_layoutRoot->container() || !m_layoutRoot->container()->needsLayout()
Summary: REGRESSION(r203415): ASSERTION FAILED: !m_layoutRoot->container() || !m_layou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-19 14:20 PDT by Ryan Haddad
Modified: 2016-07-22 00:01 PDT (History)
4 users (show)

See Also:

Attachments
Crashlog (107.80 KB, text/plain)
2016-07-19 14:20 PDT, Ryan Haddad 		no flags Details
Patch (2.99 KB, patch)
2016-07-19 15:24 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-07-19 14:20:57 PDT 
Created attachment 284051 [details]
Crashlog

ASSERTION FAILED: !m_layoutRoot->container() || !m_layoutRoot->container()->needsLayout()

Encountered with LayoutTest editing/pasteboard/drag-drop-input-in-svg.svg

Link to failing test run:
https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r203415%20(6688)/results.html
Comment 1 Ryan Haddad 2016-07-19 14:23:55 PDT 
First seen with https://trac.webkit.org/changeset/203415
Comment 2 Ryan Haddad 2016-07-19 14:29:55 PDT 
Encountered on both El Capitan and Yosemite Debug WK2
Comment 3 zalan 2016-07-19 15:00:11 PDT 
I just need to change the ASSERT to reflect the new behavior. It does not impact functionality.
Comment 4 zalan 2016-07-19 15:24:04 PDT 
Created attachment 284061 [details]
Patch
Comment 5 Simon Fraser (smfr) 2016-07-19 15:36:43 PDT 
Comment on attachment 284061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284061&action=review

> Source/WebCore/ChangeLog:10
> +        Update ASSERTs to reflect new functionality, that is, now we can end up in a state
> +        where the container (RenderView) of one of the dirty subtrees is dirty.
> +        See r203415.

Can these go away if we fix FrameSelection to not call renderView->setNeedsLayout()? If so, you should track that cleanup in a bug.
Comment 6 WebKit Commit Bot 2016-07-19 15:51:06 PDT 
Comment on attachment 284061 [details]
Patch

Clearing flags on attachment: 284061

Committed r203425: <http://trac.webkit.org/changeset/203425>
Comment 7 WebKit Commit Bot 2016-07-19 15:51:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 zalan 2016-07-20 10:36:41 PDT 
(In reply to comment #5)
> Comment on attachment 284061 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=284061&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        Update ASSERTs to reflect new functionality, that is, now we can end up in a state
> > +        where the container (RenderView) of one of the dirty subtrees is dirty.
> > +        See r203415.
> 
> Can these go away if we fix FrameSelection to not call
> renderView->setNeedsLayout()? If so, you should track that cleanup in a bug.
bug 159976
Comment 9 Radar WebKit Bug Importer 2016-07-22 00:01:40 PDT 
<rdar://problem/27488703>