Bug 159948 - REGRESSION(202927): The first slide is the only displayed slide when Quicklooking a Keynote file
Summary: REGRESSION(202927): The first slide is the only displayed slide when Quickloo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-19 13:54 PDT by Dean Jackson
Modified: 2016-07-19 15:45 PDT (History)
0 users

See Also:


Attachments
Patch (2.52 KB, patch)
2016-07-19 14:08 PDT, Dean Jackson
simon.fraser: review+
Details | Formatted Diff | Diff
Patch (3.90 KB, patch)
2016-07-19 15:04 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (4.35 KB, patch)
2016-07-19 15:18 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2016-07-19 13:54:39 PDT
REGRESSION(202927): The first slide is the only displayed slide when Quicklooking a Keynote file
Comment 1 Dean Jackson 2016-07-19 14:08:28 PDT
Created attachment 284049 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-07-19 14:17:23 PDT
Comment on attachment 284049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284049&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:91
> +        colorSpace = adoptCF(CGBitmapContextGetColorSpace(cgContext));
> +        break;
> +    case kCGContextTypeIOSurface:
> +        colorSpace = adoptCF(CGIOSurfaceContextGetColorSpace(cgContext));
> +        break;
> +    default:
> +        colorSpace = adoptCF(CGContextCopyDeviceColorSpace(cgContext));

Do you need to declare any new SPI for these?
Comment 3 Dean Jackson 2016-07-19 14:57:59 PDT
Comment on attachment 284049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284049&action=review

>> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:91
>> +        colorSpace = adoptCF(CGContextCopyDeviceColorSpace(cgContext));
> 
> Do you need to declare any new SPI for these?

Yes. I was waiting for EWS to tell me :)
Comment 4 Dean Jackson 2016-07-19 15:04:48 PDT
Created attachment 284058 [details]
Patch
Comment 5 Dean Jackson 2016-07-19 15:18:45 PDT
Created attachment 284060 [details]
Patch
Comment 6 Dean Jackson 2016-07-19 15:45:03 PDT
Committed r203424: <http://trac.webkit.org/changeset/203424>