Bug 159943 – Fix null handling of HTMLScriptElement.text attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Fix null handling of HTMLScriptElement.text attribute:
- https://html.spec.whatwg.org/multipage/scripting.html#the-script-element

We should treat null as the "null" String but we currently treat it as the empty string.

Firefox and Chrome match the specification.

[Chris Dumez]

Created attachment 284039 [details]
Patch

[Build Bot]

Comment on attachment 284039 [details]
Patch

Attachment 284039 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1708458

New failing tests:
fast/dom/element-attribute-js-null.html

[Build Bot]

Created attachment 284050 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 284039 [details]
Patch

Attachment 284039 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1708494

New failing tests:
fast/dom/element-attribute-js-null.html

[Build Bot]

Comment on attachment 284039 [details]
Patch

Attachment 284039 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1708475

New failing tests:
fast/dom/element-attribute-js-null.html

[Build Bot]

Created attachment 284052 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Created attachment 284053 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 284039 [details]
Patch

Attachment 284039 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1708469

New failing tests:
fast/dom/element-attribute-js-null.html

[Build Bot]

Created attachment 284054 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

[Chris Dumez]

Created attachment 284057 [details]
Patch

[Chris Dumez]

Comment on attachment 284057 [details]
Patch

Clearing flags on attachment: 284057

Committed r203428: <http://trac.webkit.org/changeset/203428>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.