Bug 159943 - Fix null handling of HTMLScriptElement.text attribute
Summary: Fix null handling of HTMLScriptElement.text attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-19 13:16 PDT by Chris Dumez
Modified: 2016-07-19 15:56 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2016-07-19 13:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (1021.76 KB, application/zip)
2016-07-19 14:12 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (913.56 KB, application/zip)
2016-07-19 14:24 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (1.47 MB, application/zip)
2016-07-19 14:24 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (646.66 KB, application/zip)
2016-07-19 14:24 PDT, Build Bot 		no flags Details
Patch (5.01 KB, patch)
2016-07-19 14:56 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-19 13:16:58 PDT 
Fix null handling of HTMLScriptElement.text attribute:
- https://html.spec.whatwg.org/multipage/scripting.html#the-script-element

We should treat null as the "null" String but we currently treat it as the empty string.

Firefox and Chrome match the specification.
Comment 1 Chris Dumez 2016-07-19 13:25:42 PDT 
Created attachment 284039 [details]
Patch
Comment 2 Build Bot 2016-07-19 14:12:11 PDT 
Comment on attachment 284039 [details]
Patch

Attachment 284039 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1708458

New failing tests:
fast/dom/element-attribute-js-null.html
Comment 3 Build Bot 2016-07-19 14:12:15 PDT 
Created attachment 284050 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-07-19 14:24:01 PDT 
Comment on attachment 284039 [details]
Patch

Attachment 284039 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1708494

New failing tests:
fast/dom/element-attribute-js-null.html
Comment 5 Build Bot 2016-07-19 14:24:01 PDT 
Comment on attachment 284039 [details]
Patch

Attachment 284039 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1708475

New failing tests:
fast/dom/element-attribute-js-null.html
Comment 6 Build Bot 2016-07-19 14:24:05 PDT 
Created attachment 284052 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-07-19 14:24:05 PDT 
Created attachment 284053 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-07-19 14:24:12 PDT 
Comment on attachment 284039 [details]
Patch

Attachment 284039 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1708469

New failing tests:
fast/dom/element-attribute-js-null.html
Comment 9 Build Bot 2016-07-19 14:24:16 PDT 
Created attachment 284054 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5
Comment 10 Chris Dumez 2016-07-19 14:56:28 PDT 
Created attachment 284057 [details]
Patch
Comment 11 Chris Dumez 2016-07-19 15:56:47 PDT 
Comment on attachment 284057 [details]
Patch

Clearing flags on attachment: 284057

Committed r203428: <http://trac.webkit.org/changeset/203428>
Comment 12 Chris Dumez 2016-07-19 15:56:54 PDT 
All reviewed patches have been landed.  Closing bug.