Bug 159938 - Document.createElementNS() / createAttributeNS() parameters should be mandatory
Summary: Document.createElementNS() / createAttributeNS() parameters should be mandatory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://dom.spec.whatwg.org/#document
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-19 12:39 PDT by Chris Dumez
Modified: 2016-07-19 18:46 PDT (History)
9 users (show)

See Also:

Attachments
Patch (27.84 KB, patch)
2016-07-19 12:42 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (28.55 KB, patch)
2016-07-19 13:04 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (28.72 KB, patch)
2016-07-19 18:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-19 12:39:27 PDT 
Document.createElementNS() / createAttributeNS() parameters should be mandatory:
- https://dom.spec.whatwg.org/#document

They are optional in WebKit. However, Firefox and Chrome both match the specification.
Comment 1 Chris Dumez 2016-07-19 12:42:17 PDT 
Created attachment 284032 [details]
Patch
Comment 2 Chris Dumez 2016-07-19 13:04:31 PDT 
Created attachment 284035 [details]
Patch
Comment 3 Benjamin Poulain 2016-07-19 18:02:41 PDT 
Comment on attachment 284035 [details]
Patch

IMHO, it is useful to test the exception type with shouldThrow().
Comment 4 Chris Dumez 2016-07-19 18:32:58 PDT 
Created attachment 284075 [details]
Patch
Comment 5 Chris Dumez 2016-07-19 18:46:49 PDT 
Comment on attachment 284075 [details]
Patch

Clearing flags on attachment: 284075

Committed r203441: <http://trac.webkit.org/changeset/203441>
Comment 6 Chris Dumez 2016-07-19 18:46:58 PDT 
All reviewed patches have been landed.  Closing bug.