Bug 159933 – [iOS] REGRESSION(203378): PDFDocumentImage::updateCachedImageIfNeeded() uses the unscaled size when deciding whether to cache the PDF image

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[Said Abou-Hallawa]

The r203378 did not actually fix the https://bugs.webkit.org/show_bug.cgi?id=158715 because although we have the right steps to decide whether to cache the PDF image or not, we are using the unscaled size which is wrong. The image has to be created scaled with the context.scaleFactor(). This may lead to allowing caching a PDF image which will cause the WebKit to jetsam on iOS.

[Said Abou-Hallawa]

Created attachment 284026 [details]
Patch

[Said Abou-Hallawa]

<rdar://problem/27430450>

[Simon Fraser (smfr)]

Comment on attachment 284026 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284026&action=review

> Source/WebCore/ChangeLog:8
> +        We need to use the scaled size when deciding whether to cache the PDF image or not.

Why?

> Source/WebCore/platform/graphics/cg/PDFDocumentImage.cpp:225
>  #if PLATFORM(IOS)
>      m_cachedImageRect = cachedImageRect(context, dstRect);
> +#else
> +    m_cachedImageRect = dstRect;
> +#endif

It would be good to turn these #if PLATFORM(IOS) into something more descriptive, that explains why iOS needs special behavior.

[Said Abou-Hallawa]

Created attachment 284347 [details]
Patch

[Said Abou-Hallawa]

Created attachment 284348 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 284348 [details]
Patch

Clearing flags on attachment: 284348

Committed r203606: <http://trac.webkit.org/changeset/203606>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.