Bug 159923 - Fix null handling of several HTMLDocument attributes
Summary: Fix null handling of several HTMLDocument attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/multipag...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-19 09:51 PDT by Chris Dumez
Modified: 2016-07-19 22:10 PDT (History)
9 users (show)

See Also:


Attachments
Patch (11.63 KB, patch)
2016-07-19 10:04 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-19 09:51:51 PDT
Fix null handling of several HTMLDocument attributes:
- https://html.spec.whatwg.org/multipage/dom.html#document
- https://html.spec.whatwg.org/multipage/obsolete.html#document-partial

In particular, null handling is currently incorrect in WebKit for 'dir', 'bgColor', 'fgColor', 'alinkColor', 'linkColor' and 'vlinkColor'.

Firefox and Chrome match the specification.
Comment 1 Chris Dumez 2016-07-19 10:04:36 PDT
Created attachment 284015 [details]
Patch
Comment 2 WebKit Commit Bot 2016-07-19 22:10:48 PDT
Comment on attachment 284015 [details]
Patch

Clearing flags on attachment: 284015

Committed r203443: <http://trac.webkit.org/changeset/203443>
Comment 3 WebKit Commit Bot 2016-07-19 22:10:54 PDT
All reviewed patches have been landed.  Closing bug.