Bug 159915 - Bubbles appear split for a brief moment in Messages
Summary: Bubbles appear split for a brief moment in Messages
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-18 18:40 PDT by Simon Fraser (smfr)
Modified: 2016-07-19 09:11 PDT (History)
9 users (show)

See Also:

Attachments
Patch (5.47 KB, patch)
2016-07-18 18:48 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (4.99 KB, patch)
2016-07-18 19:28 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (786.88 KB, application/zip)
2016-07-18 20:15 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (1.42 MB, application/zip)
2016-07-18 20:25 PDT, Build Bot 		no flags Details
Patch (5.89 KB, patch)
2016-07-18 21:52 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-07-18 18:40:56 PDT 
Bubbles appear split for a brief moment in Messages
Comment 1 Simon Fraser (smfr) 2016-07-18 18:48:31 PDT 
Created attachment 283970 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-07-18 19:14:56 PDT 
Comment on attachment 283970 [details]
Patch

viewRect() is affected by scale on iOS, so we don't want that.
Comment 3 Simon Fraser (smfr) 2016-07-18 19:28:46 PDT 
Created attachment 283971 [details]
Patch
Comment 4 Build Bot 2016-07-18 20:15:51 PDT 
Comment on attachment 283971 [details]
Patch

Attachment 283971 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1704597

New failing tests:
fast/repaint/scrolled-view-full-repaint.html
Comment 5 Build Bot 2016-07-18 20:15:55 PDT 
Created attachment 283972 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-07-18 20:25:50 PDT 
Comment on attachment 283971 [details]
Patch

Attachment 283971 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1704612

New failing tests:
fast/repaint/scrolled-view-full-repaint.html
Comment 7 Build Bot 2016-07-18 20:25:55 PDT 
Created attachment 283973 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Ryosuke Niwa 2016-07-18 21:07:44 PDT 
The test added in this patch is failing on WK1 the following diff:

--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fast/repaint/scrolled-view-full-repaint-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/fast/repaint/scrolled-view-full-repaint-actual.txt
@@ -1,3 +1,3 @@
 In WebKit1 there should be a repaint at 0,0.
 
-(repaint rects (rect 0 0 785 610) )
+(repaint rects (rect 0 -500 785 2024) )
Comment 9 Simon Fraser (smfr) 2016-07-18 21:40:01 PDT 
Yeah, I need to fix the results.
Comment 10 Simon Fraser (smfr) 2016-07-18 21:52:17 PDT 
Created attachment 283977 [details]
Patch
Comment 11 Jon Lee 2016-07-18 23:55:03 PDT 
rdar://problem/27182267
Comment 12 Dave Hyatt 2016-07-19 08:20:05 PDT 
Comment on attachment 283977 [details]
Patch

r=me, but more general fix would be better long-term.
Comment 13 WebKit Commit Bot 2016-07-19 09:11:36 PDT 
Comment on attachment 283977 [details]
Patch

Clearing flags on attachment: 283977

Committed r203409: <http://trac.webkit.org/changeset/203409>
Comment 14 WebKit Commit Bot 2016-07-19 09:11:41 PDT 
All reviewed patches have been landed.  Closing bug.