Bug 159908 - input.formEnctype / formMethod and button.formEnctype / formMethod / type should treat null as "null"
Summary: input.formEnctype / formMethod and button.formEnctype / formMethod / type sho...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-07-18 16:43 PDT by Chris Dumez
Modified: 2016-07-18 21:46 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.04 KB, patch)
2016-07-18 16:49 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (911.67 KB, application/zip)
2016-07-18 17:40 PDT, Build Bot 		no flags Details
Patch (20.27 KB, patch)
2016-07-18 18:19 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (20.26 KB, patch)
2016-07-18 20:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-18 16:43:40 PDT 
input.formEnctype / formMethod and button.formEnctype / formMethod / type should treat null as "null" String:
- https://html.spec.whatwg.org/multipage/forms.html#htmlinputelement
- https://html.spec.whatwg.org/multipage/forms.html#htmlbuttonelement

In WebKit, we treat null as a null String which ends up removing the corresponding attribute. This does not match the specification.
Firefox and Chrome match the specification here.
Comment 1 Chris Dumez 2016-07-18 16:49:22 PDT 
Created attachment 283960 [details]
Patch
Comment 2 Build Bot 2016-07-18 17:40:08 PDT 
Comment on attachment 283960 [details]
Patch

Attachment 283960 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1704018

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-forms.html
Comment 3 Build Bot 2016-07-18 17:40:11 PDT 
Created attachment 283966 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5
Comment 4 Chris Dumez 2016-07-18 18:19:10 PDT 
Created attachment 283968 [details]
Patch
Comment 5 Chris Dumez 2016-07-18 20:32:25 PDT 
Created attachment 283974 [details]
Patch
Comment 6 WebKit Commit Bot 2016-07-18 21:46:49 PDT 
Comment on attachment 283974 [details]
Patch

Clearing flags on attachment: 283974

Committed r203394: <http://trac.webkit.org/changeset/203394>
Comment 7 WebKit Commit Bot 2016-07-18 21:46:55 PDT 
All reviewed patches have been landed.  Closing bug.