Bug 159905 - Web Inspector: Visual Styles Sidebar should have only one column when it's narrow
Summary: Web Inspector: Visual Styles Sidebar should have only one column when it's na...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-07-18 16:18 PDT by Nikita Vasilyev
Modified: 2016-07-27 16:56 PDT (History)
8 users (show)

See Also:

Attachments
[Image] Bug (63.43 KB, image/png)
2016-07-18 16:18 PDT, Nikita Vasilyev 		no flags Details
WIP (2.74 KB, patch)
2016-07-18 16:32 PDT, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
Details | Formatted Diff | Diff
[Animated GIF] With WIP applied (544.91 KB, image/gif)
2016-07-18 16:34 PDT, Nikita Vasilyev 		no flags Details
Patch (4.21 KB, patch)
2016-07-27 15:36 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Animated GIF] With WIP applied (2.12 MB, image/gif)
2016-07-27 15:36 PDT, Nikita Vasilyev 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-07-18 16:18:15 PDT 
Created attachment 283949 [details]
[Image] Bug

CSS values are clipped and unreadable when Visual Styles Sidebar is too narrow.
Comment 1 Radar WebKit Bug Importer 2016-07-18 16:18:51 PDT 
<rdar://problem/27413248>
Comment 2 Nikita Vasilyev 2016-07-18 16:32:18 PDT 
Created attachment 283952 [details]
WIP
Comment 3 Nikita Vasilyev 2016-07-18 16:34:16 PDT 
Created attachment 283956 [details]
[Animated GIF] With WIP applied

This still needs some work as position, padding, and margin controls are broken.
Comment 4 Devin Rousso 2016-07-18 23:15:13 PDT 
(In reply to comment #3)
> Created attachment 283956 [details]
> [Animated GIF] With WIP applied
> 
> This still needs some work as position, padding, and margin controls are
> broken.

I think that if the sidebar gets small enough, it may be best to just disable/hide the Links (for position, margin, and padding).  Also, I think the reason why those properties are having issues is because they are also `.layout-reversed`, which changes the order/alignment of their contents.
Comment 5 BJ Burg 2016-07-25 11:02:34 PDT 
Comment on attachment 283952 [details]
WIP

Note: there's no need to mark WIP patches as r- and cq-. If it's not flagged r?, then nobody will r+ it. Adding r- to your own just makes it less obvious what the state of it is.
Comment 6 Nikita Vasilyev 2016-07-25 11:18:24 PDT 
(In reply to comment #5)
> Comment on attachment 283952 [details]
> WIP
> 
> Note: there's no need to mark WIP patches as r- and cq-. If it's not flagged
> r?, then nobody will r+ it. Adding r- to your own just makes it less obvious
> what the state of it is.

I believe a while ago Tim or Joe told me that setting r-/cq- on my own patch
communicates explicitly that the patch isn't ready for review/landing.
Comment 7 Nikita Vasilyev 2016-07-27 15:36:22 PDT 
Created attachment 284736 [details]
Patch
Comment 8 Nikita Vasilyev 2016-07-27 15:36:56 PDT 
Created attachment 284737 [details]
[Animated GIF] With WIP applied
Comment 9 Joseph Pecoraro 2016-07-27 16:34:20 PDT 
Comment on attachment 284736 [details]
Patch

Neat! r=me
Comment 10 WebKit Commit Bot 2016-07-27 16:55:56 PDT 
Comment on attachment 284736 [details]
Patch

Clearing flags on attachment: 284736

Committed r203807: <http://trac.webkit.org/changeset/203807>
Comment 11 WebKit Commit Bot 2016-07-27 16:56:00 PDT 
All reviewed patches have been landed.  Closing bug.