RESOLVED FIXED159905
Web Inspector: Visual Styles Sidebar should have only one column when it's narrow 
https://bugs.webkit.org/show_bug.cgi?id=159905
Summary Web Inspector: Visual Styles Sidebar should have only one column when it's na...
Nikita Vasilyev
Reported 2016-07-18 16:18:15 PDT
Created attachment 283949 [details] [Image] Bug CSS values are clipped and unreadable when Visual Styles Sidebar is too narrow.
Attachments
[Image] Bug (63.43 KB, image/png)
2016-07-18 16:18 PDT, Nikita Vasilyev 		no flags
Details
WIP (2.74 KB, patch)
2016-07-18 16:32 PDT, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
DetailsFormatted DiffDiff
[Animated GIF] With WIP applied (544.91 KB, image/gif)
2016-07-18 16:34 PDT, Nikita Vasilyev 		no flags
Details
Patch (4.21 KB, patch)
2016-07-27 15:36 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Animated GIF] With WIP applied (2.12 MB, image/gif)
2016-07-27 15:36 PDT, Nikita Vasilyev 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-07-18 16:18:51 PDT
<rdar://problem/27413248>
Nikita Vasilyev
Comment 2 2016-07-18 16:32:18 PDT
Created attachment 283952 [details] WIP
Nikita Vasilyev
Comment 3 2016-07-18 16:34:16 PDT
Created attachment 283956 [details] [Animated GIF] With WIP applied This still needs some work as position, padding, and margin controls are broken.
Devin Rousso
Comment 4 2016-07-18 23:15:13 PDT
(In reply to comment #3) > Created attachment 283956 [details] > [Animated GIF] With WIP applied > > This still needs some work as position, padding, and margin controls are > broken. I think that if the sidebar gets small enough, it may be best to just disable/hide the Links (for position, margin, and padding). Also, I think the reason why those properties are having issues is because they are also `.layout-reversed`, which changes the order/alignment of their contents.
Blaze Burg
Comment 5 2016-07-25 11:02:34 PDT
Comment on attachment 283952 [details] WIP Note: there's no need to mark WIP patches as r- and cq-. If it's not flagged r?, then nobody will r+ it. Adding r- to your own just makes it less obvious what the state of it is.
Nikita Vasilyev
Comment 6 2016-07-25 11:18:24 PDT
(In reply to comment #5) > Comment on attachment 283952 [details] > WIP > > Note: there's no need to mark WIP patches as r- and cq-. If it's not flagged > r?, then nobody will r+ it. Adding r- to your own just makes it less obvious > what the state of it is. I believe a while ago Tim or Joe told me that setting r-/cq- on my own patch communicates explicitly that the patch isn't ready for review/landing.
Nikita Vasilyev
Comment 7 2016-07-27 15:36:22 PDT
Created attachment 284736 [details] Patch
Nikita Vasilyev
Comment 8 2016-07-27 15:36:56 PDT
Created attachment 284737 [details] [Animated GIF] With WIP applied
Joseph Pecoraro
Comment 9 2016-07-27 16:34:20 PDT
Comment on attachment 284736 [details] Patch Neat! r=me
WebKit Commit Bot
Comment 10 2016-07-27 16:55:56 PDT
Comment on attachment 284736 [details] Patch Clearing flags on attachment: 284736 Committed r203807: <http://trac.webkit.org/changeset/203807>
WebKit Commit Bot
Comment 11 2016-07-27 16:56:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.