Bug 159901 - DocType's publicId / systemId should not be nullable
Summary: DocType's publicId / systemId should not be nullable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-18 15:14 PDT by Chris Dumez
Modified: 2016-07-18 17:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.76 KB, patch)
2016-07-18 15:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-07-18 15:14:07 PDT 
DocType's publicId / systemId should not be nullable. While they are not marked as nullable in our IDL, they can be stored as null Strings in our implementation. This leads to subtle bugs.
Comment 1 Chris Dumez 2016-07-18 15:33:03 PDT 
Created attachment 283946 [details]
Patch
Comment 2 Benjamin Poulain 2016-07-18 17:36:37 PDT 
Comment on attachment 283946 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283946&action=review

String sucks when it can't be null by design :(

> Source/WebCore/ChangeLog:17
> +        Serialization would DocumentType nodes would also be wrong when

"Serialization would DocumentType nodes would"
Comment 3 WebKit Commit Bot 2016-07-18 17:58:13 PDT 
Comment on attachment 283946 [details]
Patch

Clearing flags on attachment: 283946

Committed r203389: <http://trac.webkit.org/changeset/203389>
Comment 4 WebKit Commit Bot 2016-07-18 17:58:17 PDT 
All reviewed patches have been landed.  Closing bug.